1098202 - Rename imgINotificationObserver handlers and flags to be consistent with the notifications they handle

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Because notification names and roles have changed over time, the names of imgINotificationObserver handlers often do not match the notifications they handle. Making the naming consistent will make the code easier to understand and less error-prone to maintain.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 1) - Rename imgINotificationObserver handlers to be consistent with the notifications they handle

Here we go; this patch renames the imgINotificationObserver handlers used in various places in our codebase so that their name is consistent with the notification they handle. It's a pretty large patch, unfortunately, though there's nothing complex going on.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 2) - Rename Progress flags to be consistent with the corresponding notifications

Here's a second patch that renames the Progress flags to be consistent with the corresponding notifications. This also has the effect of making them more consistent with the imgIRequest STATUS_* flags they correspond to, so everything gets tied together nicely.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Here's a build-only try job on all platforms to make sure nothing went wrong:

https://tbpl.mozilla.org/?tree=Try&rev=6dc2c35eca05

Comment 4

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Comment 5

[Seth Fowler [:seth] [:s2h]]

So bug 858919 busted this. I believe it's fixed now; here's a try job to confirm:

https://tbpl.mozilla.org/?tree=Try&rev=74cdb13fb03b

Comment 6

[Seth Fowler [:seth] [:s2h]]

Attachment: (Part 1) - Rename imgINotificationObserver handlers to be consistent with the notifications they handle

Here's the updated version of part 1 that should fix the build.

Comment 7

[Seth Fowler [:seth] [:s2h]]

Looks like try is green. Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b2b5f73f8ca
https://hg.mozilla.org/integration/mozilla-inbound/rev/f15de87ae342

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b2b5f73f8ca
https://hg.mozilla.org/mozilla-central/rev/f15de87ae342