Rename imgINotificationObserver handlers and flags to be consistent with the notifications they handle

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

(Blocks: 1 bug)

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
Because notification names and roles have changed over time, the names of imgINotificationObserver handlers often do not match the notifications they handle. Making the naming consistent will make the code easier to understand and less error-prone to maintain.
(Assignee)

Updated

4 years ago
Summary: Rename imgINotificationObserver handlers to be consistent with the notifications they handle → Rename imgINotificationObserver handlers and flags to be consistent with the notifications they handle
(Assignee)

Comment 1

4 years ago
Created attachment 8522613 [details] [diff] [review]
(Part 1) - Rename imgINotificationObserver handlers to be consistent with the notifications they handle

Here we go; this patch renames the imgINotificationObserver handlers used in various places in our codebase so that their name is consistent with the notification they handle. It's a pretty large patch, unfortunately, though there's nothing complex going on.
Attachment #8522613 - Flags: review?(tnikkel)
(Assignee)

Comment 2

4 years ago
Created attachment 8522614 [details] [diff] [review]
(Part 2) - Rename Progress flags to be consistent with the corresponding notifications

Here's a second patch that renames the Progress flags to be consistent with the corresponding notifications. This also has the effect of making them more consistent with the imgIRequest STATUS_* flags they correspond to, so everything gets tied together nicely.
Attachment #8522614 - Flags: review?(tnikkel)
(Assignee)

Comment 3

4 years ago
Here's a build-only try job on all platforms to make sure nothing went wrong:

https://tbpl.mozilla.org/?tree=Try&rev=6dc2c35eca05
Attachment #8522613 - Flags: review?(tnikkel) → review+
Attachment #8522614 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 4

4 years ago
Thanks for the review!
(Assignee)

Comment 5

4 years ago
So bug 858919 busted this. I believe it's fixed now; here's a try job to confirm:

https://tbpl.mozilla.org/?tree=Try&rev=74cdb13fb03b
(Assignee)

Comment 6

4 years ago
Created attachment 8524073 [details] [diff] [review]
(Part 1) - Rename imgINotificationObserver handlers to be consistent with the notifications they handle

Here's the updated version of part 1 that should fix the build.
https://hg.mozilla.org/mozilla-central/rev/3b2b5f73f8ca
https://hg.mozilla.org/mozilla-central/rev/f15de87ae342
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.