1098218 - [Contacts] [Regression] Facebook contact photo should not be removed and user should be able to add a local photo

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Elie]

Attachment: logcat.txt

[1.Description]:
[Flame][v2.1&2.2][Contacts]Can't delete the headportrait of facebook contact.
PS:The facebook contact name can be edit,but can't be save changement.
Picture:1.png and 2.png
log:logcat.txt
Happen time:4:53

[2.Testing Steps]: 
Precondition:Impormt some contatcs from facebook
1.Launch Contacts
2.Tap a facebook contacts with headportrait
3.Tap edit->tap headportrait to edit->tap delete
>>You can see the headportrait has been deleted
4.Tap Update to save the changes

[3.Expected Result]: 
4.The contact headportrait should not be shown.

[4.Actual Result]: 
4.The contact headportrait is still shown.

[5.Reproduction build]: 
FLame2.1 build:
Gaia-Rev        4c159e75a1568afbbf0c83c1235ec56facfbe87d
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/b9849b3c6aaa
Build-ID        20141112001201
Version         34.0

FLame2.2  build:
Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/688f821edcd4
Build-ID        20141112040208
Version         36.0a1

[6.Reproduction Frequency]: 
Always Recurrence,5/5

Comment 1

[Elie]

Attachment: 1.png

Comment 2

[Elie]

Attachment: 2.png

Comment 3

[Johan Lorenzo [:jlorenzo]]

I'm sure it's by design. But in 2.0 and inferior, we don't show the delete button. So we should continue hiding this button when we have a Facebook contact. An end user might think this is a broken functionality. See video for details.

[Blocking Requested - why for this release]: Regression due to the redesign of the Edit page.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: Can't remove FB contact photo - Video

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: not a major regression so non-blocking. We want it to be fixed and uplifted so I'm nominating 2.2.

Comment 6

[Jose Manuel Cantera]

Attachment: 26258.html

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: blocking 2.2.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8524674 [details]
26258.html

Nice work, I've relaunched some works in gaia-try, but seems an integration test is not passing (related to system).

Could you rebase against master to see if it's fixed?

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Jose could you record a video for the sprint demo?

https://wiki.mozilla.org/Gaia/Contacts/Scrum/2.1S9#Demos

Comment 10

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/d695e7cdcd162e779e15594054931c84dec34a95

Comment 11

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2.

Result: "Remove photo" option no longer exists with Facebook contacts. The user can successfully change the profile photo with a local photo.

Device: Flame 2.2 (319mb, KK, Shallow Flash)
BuildID: 20141124100136
Gaia: aad40f6d6eb8f626c6a20db55b9f00d2e832f113
Gecko: be4ba3d5ca9a
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
==============================================
Leaving verifyme for 2.1 patch uplift.

Comment 12

[Shally Li（leave from Mozilla）]

The v2.2 has verified, clear 'verifyme' keywords.