1098220 - [Exception... "Component does not have requested interface [nsISettingsServiceCallback.handle]" in SettingsService.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:gerard-majax]

Saw this on some boot of device with master

> 06-01 02:42:12.869   224   224 I Gecko   : settings 'handle' callback threw an exception, dropping: [Exception... "Component does not have requested interface [nsISettingsServiceCallback.handle]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/SettingsService.js :: callHandle :: line 184"  data: no]

Comment 1

[:gerard-majax]

Kyle, maybe it's harmless and it's just a setting being set without any callback handler?

What about checking in SettingsService.js' callHandle (and others) that we do have a |.handle| property defined before using it? Maybe adding a warning.

Leaving exception like this may lure people into thinking there's a bug.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Seems like an easy enough fix, yeah.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Change dump statements to debug statements in SettingsService

Comment 4

[:gerard-majax]

Comment on attachment 8540256 [details] [diff] [review]
Patch 1 (v1) - Change dump statements to debug statements in SettingsService

Review of attachment 8540256 [details] [diff] [review]:
-----------------------------------------------------------------

I think we set debug to default to true, but the patch is fine for me. And it's trivial.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Will update patch to check for validity of .handle, and only print if DEBUG && handle is valid.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/b2g-inbound/rev/0529b5dca28e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0529b5dca28e