[Exception... "Component does not have requested interface [nsISettingsServiceCallback.handle]" in SettingsService.js

RESOLVED FIXED in mozilla37

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gerard, Assigned: qdot)

Tracking

Trunk
mozilla37
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Saw this on some boot of device with master

> 06-01 02:42:12.869   224   224 I Gecko   : settings 'handle' callback threw an exception, dropping: [Exception... "Component does not have requested interface [nsISettingsServiceCallback.handle]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/SettingsService.js :: callHandle :: line 184"  data: no]
(Reporter)

Comment 1

4 years ago
Kyle, maybe it's harmless and it's just a setting being set without any callback handler?

What about checking in SettingsService.js' callHandle (and others) that we do have a |.handle| property defined before using it? Maybe adding a warning.

Leaving exception like this may lure people into thinking there's a bug.
Flags: needinfo?(kyle)
Seems like an easy enough fix, yeah.
Flags: needinfo?(kyle)
Created attachment 8540256 [details] [diff] [review]
Patch 1 (v1) - Change dump statements to debug statements in SettingsService
Attachment #8540256 - Flags: review?(lissyx+mozillians)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8540256 [details] [diff] [review]
Patch 1 (v1) - Change dump statements to debug statements in SettingsService

Review of attachment 8540256 [details] [diff] [review]:
-----------------------------------------------------------------

I think we set debug to default to true, but the patch is fine for me. And it's trivial.
Attachment #8540256 - Flags: review?(lissyx+mozillians) → review+
(Reporter)

Updated

4 years ago
Blocks: 1107982
Will update patch to check for validity of .handle, and only print if DEBUG && handle is valid.
https://hg.mozilla.org/mozilla-central/rev/0529b5dca28e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Whiteboard: [systemsfe]
You need to log in before you can comment on or make changes to this bug.