Task to address the automation for Telemetry Data suggested in https://github.com/mozilla-b2g/firefoxos-loop-client/pull/176
Assignee: nobody → carmen.jimenezcabezas
Status: NEW → ASSIGNED
Created attachment 8523529 [details] WIP
Fernando, Antonio, this is what I having in mind. It's still untested, but if you want (and you have time) you can take a look in case you want to comments.
Created attachment 8523566 [details] WIP - testing
just an idea once you updated the API, what do you think about adding something like this instead of strings directly: Telemetry.updateReport(Telemetry.TYPE.xxxxx);
or Telemetry.update(Telemetry.REPORT.xxxxx); just ideas to improve current approach in 1.1. thanks Carmen
Created attachment 8523716 [details] [review] V1 Proposed patch
(In reply to Cristian Rodriguez (:crdlc) from comment #5) > or > > Telemetry.update(Telemetry.REPORT.xxxxx); > > just ideas to improve current approach in 1.1. thanks Carmen When you call Telemetry.update('whateverAttribute') you're giving, actually, an attribute of TelemetryReport which is a private object. In order to make something as you've proposed, although usually it's good to use a constant literal instead of the literal, in this case this would be to define as a constant the name of an attribute which is a constant already. So it would just add unneeded code lines in this case. You won't usually declare constants for the attributes of a class :).
Comment on attachment 8523716 [details] [review] V1 Proposed patch Great! Thanks for doing it! Two nits in GH. If you prefer, we can talk offline about them ;)
Attachment #8523716 - Flags: review?(frsela) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.