1098339 - Automation of Telemetry data for Loop Mobile Client application (v1.1.1)

Status: RESOLVED FIXED

Description

[Maria Angeles Oteo (:oteo)]

Task to address the automation for Telemetry Data suggested in https://github.com/mozilla-b2g/firefoxos-loop-client/pull/176

Comment 1

[Carmen Jimenez Cabezas]

Created attachment 8523529 [details]
WIP

Comment 2

[Carmen Jimenez Cabezas]

Fernando, Antonio, this is what I having in mind. 
It's still untested, but if you want (and you have time) you can take a look in case you want to comments.

Comment 3

[Carmen Jimenez Cabezas]

Created attachment 8523566 [details]
WIP - testing

Comment 4

[Cristian Rodriguez (:crdlc)]

just an idea once you updated the API, what do you think about adding something like this instead of strings directly:

Telemetry.updateReport(Telemetry.TYPE.xxxxx);

Comment 5

[Cristian Rodriguez (:crdlc)]

or

Telemetry.update(Telemetry.REPORT.xxxxx);

just ideas to improve current approach in 1.1. thanks Carmen

Comment 6

[Carmen Jimenez Cabezas]

Created attachment 8523716 [details] [review]
V1 Proposed patch

Comment 7

[Carmen Jimenez Cabezas]

(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> or
> 
> Telemetry.update(Telemetry.REPORT.xxxxx);
> 
> just ideas to improve current approach in 1.1. thanks Carmen

When you call Telemetry.update('whateverAttribute') you're giving, actually, an attribute of TelemetryReport which is a private object.
In order to make something as you've proposed, although usually it's good to use a constant literal instead of the literal, in this case this would be to define as a constant the name of an attribute which is a constant already. 
So it would just add unneeded code lines in this case. You won't usually declare constants for the attributes of a class :).

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8523716 [details] [review]
V1 Proposed patch

Great! Thanks for doing it!
Two nits in GH. If you prefer, we can talk offline about them ;)

Comment 9

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/e31cc31eaa55a75967a02ce7b305478eff230882