Closed
Bug 1098339
Opened 11 years ago
Closed 11 years ago
Automation of Telemetry data for Loop Mobile Client application (v1.1.1)
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: oteo, Assigned: macajc)
References
Details
Attachments
(1 file, 2 obsolete files)
Task to address the automation for Telemetry Data suggested in https://github.com/mozilla-b2g/firefoxos-loop-client/pull/176
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → carmen.jimenezcabezas
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8523529 -
Flags: feedback?(frsela)
Attachment #8523529 -
Flags: feedback?(amac.bug)
Assignee | ||
Comment 2•11 years ago
|
||
Fernando, Antonio, this is what I having in mind.
It's still untested, but if you want (and you have time) you can take a look in case you want to comments.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8523566 -
Flags: feedback?(frsela)
Attachment #8523566 -
Flags: feedback?(amac.bug)
Assignee | ||
Updated•11 years ago
|
Attachment #8523529 -
Attachment is obsolete: true
Attachment #8523529 -
Flags: feedback?(frsela)
Attachment #8523529 -
Flags: feedback?(amac.bug)
Comment 4•11 years ago
|
||
just an idea once you updated the API, what do you think about adding something like this instead of strings directly:
Telemetry.updateReport(Telemetry.TYPE.xxxxx);
Comment 5•11 years ago
|
||
or
Telemetry.update(Telemetry.REPORT.xxxxx);
just ideas to improve current approach in 1.1. thanks Carmen
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8523566 -
Attachment is obsolete: true
Attachment #8523566 -
Flags: feedback?(frsela)
Attachment #8523566 -
Flags: feedback?(amac.bug)
Attachment #8523716 -
Flags: review?(frsela)
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> or
>
> Telemetry.update(Telemetry.REPORT.xxxxx);
>
> just ideas to improve current approach in 1.1. thanks Carmen
When you call Telemetry.update('whateverAttribute') you're giving, actually, an attribute of TelemetryReport which is a private object.
In order to make something as you've proposed, although usually it's good to use a constant literal instead of the literal, in this case this would be to define as a constant the name of an attribute which is a constant already.
So it would just add unneeded code lines in this case. You won't usually declare constants for the attributes of a class :).
Comment 8•11 years ago
|
||
Comment on attachment 8523716 [details] [review]
V1 Proposed patch
Great! Thanks for doing it!
Two nits in GH. If you prefer, we can talk offline about them ;)
Attachment #8523716 -
Flags: review?(frsela) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•