1098470 - navigator.hasFeature() returns undefined for manifest.*

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mathieu Pillard [:mat]]

Attachment: Test app showing that hasFeature('manifest.<*>') return undefined

According to https://wiki.mozilla.org/WebAPI/Navigator.hasFeature, from a privileged app with the 'feature-detection' permission, I should be able to use hasFeature() to detect 'manifest.precompile' support. It doesn't work. Try:

navigator.hasFeature('manifest.precompile').then(function(data) { console.log(data); });

Expected result:
true

Actual result:
undefined

Attaching a small privileged app exhibiting the issue. Pushing and running it with WebIDE should display a green table, but all the manifest.* rows are red instead.

Interestingly, through hasFeature() fails, getFeature() works for manifest.*, but then the table results are inverted: all api.* return undefined for getFeature(), manifest.* return true.

Comment 1

[:Harald Kirschner :digitarald]

[Blocking Requested - why for this release]:

Ehsan, can you confirm that the implementation [1] differs from the design?

Reuben, would you have time to take a look at this, as you did the initial work?

[1]: http://dxr.mozilla.org/mozilla-central/source/dom/base/test/test_getFeature_with_perm.html#98

Comment 2

[:Harald Kirschner :digitarald]

[Blocking Requested - why for this release]: The getFeature implementation differs from its original design, which needs to be fixed.

Comment 3

[Reuben Morais [:reuben]]

The documentation is kind of confusing on this one. GetFeature and HasFeature were split up, and so far HasFeature only covers the api.* namespace. For manifest.*, you need to use GetFeature. I'm pretty sure this is INVALID.

Comment 4

[Reuben Morais [:reuben]]

(See bug 1009645 comment 76 and the comments after that.)

Comment 5

[Reuben Morais [:reuben]]

Attachment: Move manifest.* scope from navigator.getFeature to navigator.hasFeature

Oh, I see. _That's_ the bug. The wiki makes more sense than the code. Sorry for the noise.

Comment 6

[(no longer active)]

Reuben, can you please add tests for this?  Thanks!

Comment 7

[Reuben Morais [:reuben]]

Thanks for the review!

https://hg.mozilla.org/integration/b2g-inbound/rev/24b10dc8139d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24b10dc8139d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request b2g34 approval on this patch when you get a chance.

Comment 10

[Reuben Morais [:reuben]]

Comment on attachment 8523302 [details] [diff] [review]
Move manifest.* scope from navigator.getFeature to navigator.hasFeature

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 900241
User impact if declined: Throws app developers a curve ball, implementation doesn't match API in weird ways.
Testing completed: Automated tests, patch has been in central for a week.
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/563cdedd6410