UITour: addNavBarWidget logging references an undefined variable

RESOLVED FIXED in Firefox 35

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

Trunk
Firefox 36
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox33 wontfix, firefox34 wontfix, firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The logging for error cases references data.target but data is not defined. Luckily the logging only occurs in error cases which we shouldn't hit in our production tours.
Flags: qe-verify-
Flags: firefox-backlog+
/r/597 - Bug 1098482 - UITour: addNavBarWidget logging references an undefined variable. r=dolske

Pull down this commit:

hg pull review -r 239c95724ae8025c6ae89ef3d810bdce487b1549
Attachment #8522420 - Flags: review?(dolske) → review+
Attachment #8522420 - Flags: review+
Attachment #8522420 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/08a902c3135e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Comment on attachment 8522420 [details]
MozReview Request: bz://1098482/MattN

[Triage Comment]

Needed for Fx35 Hello tour, trivial fix.

(Already on aurora via the trains, so only a beta a+ is needed.)
Attachment #8522420 - Flags: approval-mozilla-beta+
Depends on bug 1097587, which needs major rebasing for Fx35.
Attachment #8522420 - Attachment is obsolete: true
Attachment #8618632 - Flags: review+
You need to log in before you can comment on or make changes to this bug.