1098482 - UITour: addNavBarWidget logging references an undefined variable

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Matthew N. [:MattN]]

The logging for error cases references data.target but data is not defined. Luckily the logging only occurs in error cases which we shouldn't hit in our production tours.

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1098482/MattN

Comment 2

[Matthew N. [:MattN]]

/r/597 - Bug 1098482 - UITour: addNavBarWidget logging references an undefined variable. r=dolske

Pull down this commit:

hg pull review -r 239c95724ae8025c6ae89ef3d810bdce487b1549

Comment 3

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/595/#review253

Ship It!

Comment 4

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/595/#review255

Ship It!

Comment 5

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/595/#review257

Ship It!

Comment 6

[Matthew N. [:MattN]]

Use this to checkin from mozreview: https://reviewboard-hg.mozilla.org/gecko/rev/239c95724ae8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/08a902c3135e

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/08a902c3135e

Comment 9

[Justin Dolske [:Dolske]]

Comment on attachment 8522420 [details]
MozReview Request: bz://1098482/MattN

[Triage Comment]

Needed for Fx35 Hello tour, trivial fix.

(Already on aurora via the trains, so only a beta a+ is needed.)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Depends on bug 1097587, which needs major rebasing for Fx35.

Comment 11

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2e46c38b44eb

Comment 13

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1098482 - UITour: addNavBarWidget logging references an undefined variable. r=dolske