Closed Bug 1098482 Opened 6 years ago Closed 6 years ago

UITour: addNavBarWidget logging references an undefined variable

Categories

(Firefox :: General, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 36
Iteration:
36.3
Tracking Status
firefox33 --- wontfix
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file, 1 obsolete file)

The logging for error cases references data.target but data is not defined. Luckily the logging only occurs in error cases which we shouldn't hit in our production tours.
Flags: qe-verify-
Flags: firefox-backlog+
Attached file MozReview Request: bz://1098482/MattN (obsolete) —
Attachment #8522420 - Flags: review?(dolske)
/r/597 - Bug 1098482 - UITour: addNavBarWidget logging references an undefined variable. r=dolske

Pull down this commit:

hg pull review -r 239c95724ae8025c6ae89ef3d810bdce487b1549
Attachment #8522420 - Flags: review?(dolske) → review+
Attachment #8522420 - Flags: review+
Attachment #8522420 - Flags: review+
Use this to checkin from mozreview: https://reviewboard-hg.mozilla.org/gecko/rev/239c95724ae8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/08a902c3135e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Comment on attachment 8522420 [details]
MozReview Request: bz://1098482/MattN

[Triage Comment]

Needed for Fx35 Hello tour, trivial fix.

(Already on aurora via the trains, so only a beta a+ is needed.)
Attachment #8522420 - Flags: approval-mozilla-beta+
Depends on bug 1097587, which needs major rebasing for Fx35.
Attachment #8522420 - Attachment is obsolete: true
Attachment #8618632 - Flags: review+
You need to log in before you can comment on or make changes to this bug.