1098598 - Crash report dialog missing the name of the app that crashed - {{name}} just crashed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of crash reporter dialog

Flame, while running:

Gaia   be8b0151d2f9a4c41fc63952128e0b723cd1161d
SourceStamp ab137ddd3746
BuildID 20141113040205
Version 36.0a1
v188

1. Crashed scrolling a page in browser
2. Observe the attached screenshot - Name of crashing app is missing

Comment 1

[Manuel Casas Barrado [:mancas]]

This issue is caused by this line:

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/crash_reporter.js#L157

If the app name is |null| then we will see |{{name}}| otherwise, the name of the app will be displayed or nothing if the app doesn't have name

Comment 2

[Aus Lacroix [:aus]]

Taking.

Comment 3

[Aus Lacroix [:aus]]

Will start work on this this week.

Comment 4

[Aus Lacroix [:aus]]

Despite crashing the browser and other apps several times via kill, I've been unable to reproduce the issue. However, it's quite possible that 'app' that crashed has no name under certain circumstances. In this particular case, we should display something. I'm flagging UX for recommendations here.

My own suggestion, actually display 'something' making it 'Something just crashed.'

Comment 5

[Rob MacDonald [:robmac]]

I'm fine with Aus's proposal. "Something just crashed." Thanks!

Comment 6

[Aus Lacroix [:aus]]

Attachment: Pull Request - Use default app name when crashedAppName is null in CrashReporter

The only way to properly test this is via unit-tests. There are currently no unit-tests for the CrashReporter. I will add some basic tests before asking for review.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8538850 [details] [review]
Pull Request - Use default app name when crashedAppName is null in CrashReporter

This seems fine to land for now as it's better than what we currently have. Ideally we would probably find a way to populate this with "Browser" in the future.

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/abca71dac6920898c5a9068e2bffc0877fd5f838

Comment 9

[Francesco Lodolo [:flod]]

Personally I would have gone with "The app", "This app", "Unidentified app".

Anyhow, is it possible to add a note in the localization file? Without the bug that "Something" doesn't make any sense.

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

I also think "Something" does not really make sense...

*2.2
Build ID               20150416162504
Gaia Revision          d50b8a3919a7b4d8d289f150d3b9bed704ebafa9
Gaia Date              2015-04-16 21:46:57
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5ebf32030512
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.195720
Firmware Date          Thu Apr 16 19:57:29 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150416160206
Gaia Revision          3cd0a9facce26c2acc7be3755a17131a6358e33f
Gaia Date              2015-04-16 16:33:22
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/51e3cb11a258
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.191700
Firmware Date          Thu Apr 16 19:17:10 EDT 2015
Bootloader             L1TC000118D0