1098611 - [FTU] UI does not update when switching networks in FTU

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Seth Miko [:SMiko]]

Attachment: wifi.png

Description: Multiple wifi networks show as "connected" in FTU 

Repro Steps:
1: Update a Flame to 20141113040205.
2: In the FTU chose a wifi network and connect to it.
3: Chose another wifi network and connect to it.

Actual: All networks that have been connected show as connected.

Expected: Only the connected network is shown as connected.

Device: Flame 2.2 (319mb/shallow flash)
BuildID: 20141113040205
Gaia: be8b0151d2f9a4c41fc63952128e0b723cd1161d
Gecko: ab137ddd3746
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Notes:
1: Tapping "Refresh" will correct the UI.

Repro frequency: 5/5

See attached: screenshot

Comment 1

[Seth Miko [:SMiko]]

This issue does NOT repro on Flame 2.1 (319mb/shalow flash)

Actual result: Only the connected network displays as "connected"

Device: Flame 2.1
BuildID: 20141113001200
Gaia: 569a299ca446f714cd98d5881cc058fd6f6e257b
Gecko: d188e92aa5a6
Gonk: 
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

This issue DOES repro on yesterday's Flame 2.2 (319mb/shallow flash)

Actual results: Multiple networks are shown as "connected"

Device: Flame 2.2
BuildID: 20141112040208
Gaia: 5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko: 688f821edcd4
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Peter Bylenga [:PBylenga]]

Regression of a core feature.

Requesting a window.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20141111043606
Gaia: 029c196eeb3848b95d66e8f91b10b2953754b4d9
Gecko: e74a1d406661
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20141111052305
Gaia: 4961cb7c9d0b4c2e5d0bc8a2a9e34965b9ad3bdf
Gecko: c6d68121d4ae
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 4961cb7c9d0b4c2e5d0bc8a2a9e34965b9ad3bdf
Gecko: e74a1d406661

First Broken Gecko & Last Working Gaia - issue does NOT repro
Gaia: 029c196eeb3848b95d66e8f91b10b2953754b4d9
Gecko: c6d68121d4ae

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/029c196eeb3848b95d66e8f91b10b2953754b4d9...4961cb7c9d0b4c2e5d0bc8a2a9e34965b9ad3bdf

Caused by Bug 1067677.

Comment 4

[Joshua Mitchell (Inactive)]

Caused by Bug 1067677 - can you take a look Fernando?

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

It was a minor issue, related with the network that you were updating.

Thanks!

Comment 6

[Fernando Campo (:fcampo)]

Comment on attachment 8524574 [details] [review]
Proposed patch

As mentioned offline, when we try to connect to a new network, the previously connected networks appears as 'Offline', instead of showing the security of the network.

Also, a basic test to check if the previous and current network states are updated, and the one we're connected is the first on the list would be much appreciated. 
It could be part of the 'join network' suite.

Comment 7

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8524574 [details] [review]
Proposed patch

Fernando, I've solved the issue. Besides I've added the unit tests you suggested.

Thanks!

Comment 8

[Fernando Campo (:fcampo)]

Comment on attachment 8524574 [details] [review]
Proposed patch

Cool, works perfect on device. Thanks Manuel!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/f708bebe1a093f8035735536f2056e695a58370c

Comment 10

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: Only the connected network is shown as connected.

Device: Flame 2.2 (319mb, KK, Full/Shallow Flash)
BuildID: 20141201040205
Gaia: 39214fb22c203e8849aaa1c27b773eeb73212921
Gecko: 08be3008650f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0