Closed
Bug 1098628
Opened 10 years ago
Closed 10 years ago
Remove ReportPendingException call in nsXBLProtoImplAnonymousMethod::Execute
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
4.25 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Once again the hard part will be finding a test that touches the right code.
|
||
Comment 1•10 years ago
|
||
You could steal something like http://mxr.mozilla.org/mozilla-central/source/dom/xbl/test/test_bug389322.xhtml with everything except the <constructor> bit removed from the binding and make the code in <constructor> throw.
|
Assignee | |
Comment 2•10 years ago
|
||
Thanks, Boris! You saved me a /ton/ of time this morning!
Attachment #8523081 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
||
Comment 4•10 years ago
|
||
>+ <script>var ctorRan = false;</script>
Don't think you need this part.
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8523081 [details] [diff] [review]
xblprotoimplanonymousmethod-v0.diff
Review of attachment 8523081 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/xbl/test/test_bug1098628_throw_from_construct.xhtml
@@ +5,5 @@
> +<head>
> + <title>Test for Bug 1098628</title>
> + <script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
> + <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
> + <script>var ctorRan = false;</script>
As bz noted, this is spurious.
Attachment #8523081 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
|
|
Assignee | |
Comment 7•10 years ago
|
||
D'oh! I landed this with the wrong bug#, so the resolution got dropped in bug 1070049 by mistake.
https://hg.mozilla.org/mozilla-central/rev/659549fa7af0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•