Closed Bug 1098639 Opened 5 years ago Closed 5 years ago

The Edit Bookmark Panel animates when opening.

Categories

(SeaMonkey :: General, defect)

SeaMonkey 2.30 Branch
x86_64
Windows 8.1
defect
Not set

Tracking

(seamonkey2.34 fixed)

RESOLVED FIXED
seamonkey2.34
Tracking Status
seamonkey2.34 --- fixed

People

(Reporter: rexyrexy2, Assigned: philip.chee)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 SeaMonkey/2.30
Build ID: 20141013232806

Steps to reproduce:

Clicked the bookmark menu to edit a bookmark.


Actual results:

The Firefox Astralis menu animation is displayed, which does not fit in with SeaMonkey, and should not have been ported over.


Expected results:

The menu animation from Firefox Australis should not have been ported to SeaMonkey
We don't have Australis. Have you installed a third party theme? Or an extension? I know that there are several themes and extensions that purport to make the SeaMonkey UI more like Firefox.
(In reply to Philip Chee from comment #1)
> We don't have Australis. Have you installed a third party theme? Or an
> extension?
Flags: needinfo?(rexyrexy2)
Firefox recently added a bookmark menu animation. (when you click bookmark button to edit it) This animation seems to have been part of Australis, and it doesn't really fit in with SeaMonkey's design. 

Click on the bookmark button when the page is already added. There is an animation. that animation was added to firefox as part of Australis' design. I believe it does not fit with SeaMonkey, and should not be in SeaMonkey.
Flags: needinfo?(rexyrexy2)
And, I'm using the built-in "Modern" theme, so it most likely is not part of the theme. (which is also the way it is in Firefox)
I see it thanks. This is Bug 610545 (arrow panels should animate when opening and when cancelling). This animation is not part of Australis but is a platform wide change.

To prevent panel popups from animating when opening it suffices to add |animate="false"| to the edit bookmark panel: <panel id="editBookmarkPanel">
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Firefox's Australis menu animations can be seen if you edit a bookmark → The Edit Bookmark Panel animates when opening.
Attached patch Patch v1.0 stop the animation. (obsolete) — Splinter Review
Hmm. I don't know. I think the animation is rather neat. What do you think Neil?
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8529889 - Flags: review?(neil)
I don't mind either way. Try posting in the newsgroup or forum for more feedback?
(In reply to neil@parkwaycc.co.uk from comment #7)
> I don't mind either way. Try posting in the newsgroup or forum for more
> feedback?
on mozilla.support.seamonkey respondents are either "don't care" or in favour.
on Mozillazine respondents are either "don't care" or violently against.

Erring on the conservative side, I think we should go ahead with this patch.
Flags: needinfo?(neil)
Comment on attachment 8529889 [details] [diff] [review]
Patch v1.0 stop the animation.

The doorhanger notifications are supposed to animate (this appears to have been broken by bug 1067367) so it would be incorrect to take the patch in this form.
Attachment #8529889 - Flags: review?(neil) → review-
would it at all be possible to have a boolean pref for this, or is that not possible or too complicated?
(In reply to neil@parkwaycc.co.uk from comment #9)
> The doorhanger notifications are supposed to animate (this appears to have
> been broken by bug 1067367) so it would be incorrect to take the patch in
> this form.
Fixed an other arrow panel in navigator.xul
Attachment #8529889 - Attachment is obsolete: true
Flags: needinfo?(neil)
Attachment #8540533 - Flags: review?(neil)
Attachment #8540533 - Flags: review?(neil) → review+
(In reply to rexyrexy2 from comment #10)
> would it at all be possible to have a boolean pref for this, or is that not
> possible or too complicated?
Possible? yes. But not worth the effort. A userChrome.css or a Stylish userstyle would proably surfice.
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/93cf0affd494
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.34
You need to log in before you can comment on or make changes to this bug.