1098639 - The Edit Bookmark Panel animates when opening.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[rexyrexy2]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0 SeaMonkey/2.30
Build ID: 20141013232806

Steps to reproduce:

Clicked the bookmark menu to edit a bookmark.


Actual results:

The Firefox Astralis menu animation is displayed, which does not fit in with SeaMonkey, and should not have been ported over.


Expected results:

The menu animation from Firefox Australis should not have been ported to SeaMonkey

Comment 1

[Philip Chee]

We don't have Australis. Have you installed a third party theme? Or an extension? I know that there are several themes and extensions that purport to make the SeaMonkey UI more like Firefox.

Comment 2

[Philip Chee]

(In reply to Philip Chee from comment #1)
> We don't have Australis. Have you installed a third party theme? Or an
> extension?

Comment 3

[rexyrexy2]

Firefox recently added a bookmark menu animation. (when you click bookmark button to edit it) This animation seems to have been part of Australis, and it doesn't really fit in with SeaMonkey's design. 

Click on the bookmark button when the page is already added. There is an animation. that animation was added to firefox as part of Australis' design. I believe it does not fit with SeaMonkey, and should not be in SeaMonkey.

Comment 4

[rexyrexy2]

And, I'm using the built-in "Modern" theme, so it most likely is not part of the theme. (which is also the way it is in Firefox)

Comment 5

[Philip Chee]

I see it thanks. This is Bug 610545 (arrow panels should animate when opening and when cancelling). This animation is not part of Australis but is a platform wide change.

To prevent panel popups from animating when opening it suffices to add |animate="false"| to the edit bookmark panel: <panel id="editBookmarkPanel">

Comment 6

[Philip Chee]

Attachment: Patch v1.0 stop the animation.

Hmm. I don't know. I think the animation is rather neat. What do you think Neil?

Comment 7

[[e-mail]]

I don't mind either way. Try posting in the newsgroup or forum for more feedback?

Comment 8

[Philip Chee]

(In reply to [e-mail] from comment #7)
> I don't mind either way. Try posting in the newsgroup or forum for more
> feedback?
on mozilla.support.seamonkey respondents are either "don't care" or in favour.
on Mozillazine respondents are either "don't care" or violently against.

Erring on the conservative side, I think we should go ahead with this patch.

Comment 9

[[e-mail]]

Comment on attachment 8529889 [details] [diff] [review]
Patch v1.0 stop the animation.

The doorhanger notifications are supposed to animate (this appears to have been broken by bug 1067367) so it would be incorrect to take the patch in this form.

Comment 10

[rexyrexy2]

would it at all be possible to have a boolean pref for this, or is that not possible or too complicated?

Comment 11

[Philip Chee]

Attachment: Patch v2.0 Fix all arrow panels in /suite/

(In reply to [e-mail] from comment #9)
> The doorhanger notifications are supposed to animate (this appears to have
> been broken by bug 1067367) so it would be incorrect to take the patch in
> this form.
Fixed an other arrow panel in navigator.xul

Comment 12

[Philip Chee]

(In reply to rexyrexy2 from comment #10)
> would it at all be possible to have a boolean pref for this, or is that not
> possible or too complicated?
Possible? yes. But not worth the effort. A userChrome.css or a Stylish userstyle would proably surfice.

Comment 13

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/93cf0affd494