Closed Bug 1098678 Opened 5 years ago Closed 5 years ago

Implement TimestampsFuzzyEqual for MP4ContainerParser

Categories

(Core :: Audio/Video, defect)

29 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is affecting us for some videos.
Even for webm, TimestampsFuzzyEqual is not fuzzy enough for variable frame sizes.
I just guessed 1000us, as I was frequently seeing gaps of ~300. Not sure if we should try base this on something more concrete.
Assignee: nobody → matt.woodrow
Attachment #8528121 - Flags: review?(ajones)
Comment on attachment 8528121 [details] [diff] [review]
Implement FuzzyEquals

Review of attachment 8528121 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/ContainerParser.cpp
@@ +274,5 @@
>      MSE_DEBUG("MP4ContainerParser(%p)::ParseStartAndEndTimestamps: [%lld, %lld]",
>                this, aStart, aEnd);
>      return true;
>    }
> +  

Whitespace.
Attachment #8528121 - Flags: review?(ajones) → review+
(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> I just guessed 1000us, as I was frequently seeing gaps of ~300. Not sure if
> we should try base this on something more concrete.

Add a follow up bug for that so it doesn't get lost.
Depends on: 1105132
https://hg.mozilla.org/mozilla-central/rev/b89eda469114
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.