1098678 - Implement TimestampsFuzzyEqual for MP4ContainerParser

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matt Woodrow (:mattwoodrow)]

This is affecting us for some videos.

Comment 1

[Karl Tomlinson (:karlt)]

Even for webm, TimestampsFuzzyEqual is not fuzzy enough for variable frame sizes.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Implement FuzzyEquals

I just guessed 1000us, as I was frequently seeing gaps of ~300. Not sure if we should try base this on something more concrete.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8528121 [details] [diff] [review]
Implement FuzzyEquals

Review of attachment 8528121 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/ContainerParser.cpp
@@ +274,5 @@
>      MSE_DEBUG("MP4ContainerParser(%p)::ParseStartAndEndTimestamps: [%lld, %lld]",
>                this, aStart, aEnd);
>      return true;
>    }
> +  

Whitespace.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> I just guessed 1000us, as I was frequently seeing gaps of ~300. Not sure if
> we should try base this on something more concrete.

Add a follow up bug for that so it doesn't get lost.

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b89eda469114

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b89eda469114