1099053 - [MarionetteTest] test_emergency_label.js doesn't successfully recover the ecclist

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Fix setEccListProperty

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Comment on attachment 8522895 [details] [diff] [review]
Fix setEccListProperty

Review of attachment 8522895 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_emergency_label.js
@@ +11,5 @@
>  
> +  // We should wrap empty |list| by ''. Otherwise, the entire command will be
> +  // "setprop ril.ecclist" which causus the command error.
> +  if (!list) {
> +    list = "''";

Hi Aknow, for this test, isn't [1] enough? I didn't see a command error when running this test... Please let me know if I misunderstand the issue. Thank you!

[1] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/test/marionette/test_emergency_label.js?from=test_emergency_label.js&case=true#29

Comment 3

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Comment on attachment 8522895 [details] [diff] [review]
Fix setEccListProperty

Review of attachment 8522895 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Please forget about comment 2 ...

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai (OOO Nov. 20) [:hsinyi] from comment #3)
> Comment on attachment 8522895 [details] [diff] [review]
> Fix setEccListProperty
> 
> Review of attachment 8522895 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good! Please forget about comment 2 ...

Oh! I'm late. Just update the details here.

The entire shell command will be something like...
=> adb shell setprop ril.ecclist

The command succeed. However, it doesn't work as we expected because of the syntax error (usage: setprop <key> <value>)

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Fix setEccListProperty. r=hsinyi

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

try looks good
https://tbpl.mozilla.org/?tree=Try&rev=28ffc3773fcc

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/952d1268e162

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/952d1268e162