1099148 - Implement Canvas2D resetTransform method

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Florian Scholz (Open Web Docs)]

void ctx.resetTransform()
Changes the transformation matrix to the identity matrix (default state).

Currently, ctx.setTransform(1, 0, 0, 1, 0, 0) can be used to achieve the same.

Implemented and enabled by default in Chrome: https://code.google.com/p/chromium/issues/detail?id=277110
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=84006

MDN: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.resetTransform

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Add resetTransform() method and a simple test for it (the test does fail if resetTransform is removed)

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8523074 [details] [diff] [review]
Add resetTransform() method and a simple test for it (the test does fail if resetTransform is removed)

Review of attachment 8523074 [details] [diff] [review]:
-----------------------------------------------------------------

There are web-platform tests that probably need to be updated now that this is implemented.

http://mxr.mozilla.org/mozilla-central/source/testing/web-platform/meta/html/dom/interfaces.html.ini#2217

Of course if we still don't pass that test we should figure out why.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks for the heads up Kyle - let's see if it passes with the additional change you suggested... https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=97af9314f20b

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Add resetTransform() and tests for it, and remove it from the list of interfaces that should fail. Carry r=bz,gw280,khuey

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=87413626cc3d

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41d8d6b0fbab

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/41d8d6b0fbab

Comment 8

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/Firefox/Releases/36#Interfaces.2FAPIs.2FDOM
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D.resetTransform