Closed
Bug 1099329
Opened 11 years ago
Closed 8 years ago
Remove __iterator__ implementations
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: evilpies, Unassigned)
References
Details
Attachments
(1 obsolete file)
I see a bunch of code that has __iterator__, this should go away. Especially ContentPrefStore.jsm seems to use it heavily.
http://mxr.mozilla.org/mozilla-central/search?string=__iterator__&find=toolkit%2F&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=mozilla-central
|
Reporter | |
Comment 1•11 years ago
|
||
ContentPrefStore is at least quite self-contained, but the uses in osfile bleed everywhere. Yoric can you take a look at eliminating: for .. in over iterators, legacy generators and __iterator__ from that?
Flags: needinfo?(dteller)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Attachment #8523431 -
Flags: review?(adw)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8523431 -
Attachment is obsolete: true
Attachment #8523431 -
Flags: review?(adw)
|
||
Comment 3•11 years ago
|
||
I filed bug 938704 a long time ago for this. Unfortunately, some code (FHR?) depended on OS.File actually using StopIteration, and I haven't had time to investigate in depth.
Depends on: 938704
Flags: needinfo?(dteller)
|
|
Reporter | |
Updated•11 years ago
|
|
|
Reporter | |
Comment 4•8 years ago
|
||
__iterator__ has been improved, I don't see any uses in dxr.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•