Closed Bug 1099329 Opened 6 years ago Closed 2 years ago

Remove __iterator__ implementations

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: evilpie, Unassigned)

References

Details

Attachments

(1 obsolete file)

I see a bunch of code that has __iterator__, this should go away. Especially ContentPrefStore.jsm seems to use it heavily.

http://mxr.mozilla.org/mozilla-central/search?string=__iterator__&find=toolkit%2F&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=mozilla-central
ContentPrefStore is at least quite self-contained, but the uses in osfile bleed everywhere. Yoric can you take a look at eliminating: for .. in over iterators, legacy generators and __iterator__ from that?
Flags: needinfo?(dteller)
Attached patch Fix ContentPrefStore (obsolete) — Splinter Review
Attachment #8523431 - Flags: review?(adw)
Attachment #8523431 - Attachment is obsolete: true
Attachment #8523431 - Flags: review?(adw)
I filed bug 938704 a long time ago for this. Unfortunately, some code (FHR?) depended on OS.File actually using StopIteration, and I haven't had time to investigate in depth.
Depends on: 938704
Flags: needinfo?(dteller)
Blocks: 1127084
No longer blocks: 1127084
Depends on: 1127084
__iterator__ has been improved, I don't see any uses in dxr.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.