Closed Bug 1099436 Opened 5 years ago Closed 5 years ago

Add telemetry for dismissing Onboarding start pane

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 36
Tracking Status
firefox34 --- verified
firefox35 --- verified
firefox36 --- verified

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file)

We should also include telemetry on dismissing the
...dismissing the onboarding start pane.
I was talking to Anthony about onboarding telemetry and suddenly realized that we don't have telemetry for dismissing/canceling the onboarding screen.

I'll want to request beta uplift for this, because it'll be really good to have these stats on release, and since the merge will be delayed until after Thanksgiving this should make it...?
Attachment #8523333 - Flags: review?(mark.finkle)
Status: NEW → ASSIGNED
Comment on attachment 8523333 [details] [diff] [review]
Patch: Add telemetry for canceling/dismissing the start pane

>diff --git a/mobile/android/base/StartPane.java b/mobile/android/base/StartPane.java

My gut instinct is saying that we don't need to treat these as two different things. In both cases, the onboarding is dismissed by the user, even though it's technically two different ways.

If you think we have a reason to track them separately, I could be swayed.

If we could get by with a single Extra, I would suggest "firstrun-popup" or "firstrun-pane". Looks like we already use "firstrun-homepage" as the Extra for the Banner telemetry.

>+    public void onCancel(DialogInterface dialog) {
>+        // StartPane is closed by touching outside the dialog.
>+        Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.DIALOG, "firstrun-cancel");

I do think this should be TelemetryContract.Event.CANCEL

>     private void addDismissHandler(View view) {
>         final GestureDetector gestureDetector = new GestureDetector(getActivity(), new GestureDetector.SimpleOnGestureListener() {
>             @Override
>             public boolean onSingleTapUp(MotionEvent e) {
>+                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.DIALOG, "firstrun-dismiss");

Same -> TelemetryContract.Event.CANCEL

Even though I could be swayed on using two different Extras, I think we do want to use TelemetryContract.Event.CANCEL for the Event.
Attachment #8523333 - Flags: review?(mark.finkle) → review+
> 
> Even though I could be swayed on using two different Extras, I think we do
> want to use TelemetryContract.Event.CANCEL for the Event.

Yep, sounds good to me.

https://hg.mozilla.org/integration/fx-team/rev/7fe78086ac8a
Target Milestone: --- → Firefox 36
Comment on attachment 8523333 [details] [diff] [review]
Patch: Add telemetry for canceling/dismissing the start pane

Approval Request Comment
[Feature/regressing bug #]: Onboarding telemetry
[User impact if declined]: Won't be able to tell how many users exit onboarding without clicking either of our two button options
[Describe test coverage new/current, TBPL]: beta try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5f28a683df8a
[Risks and why]: very low, just adding telemetry probes
[String/UUID change made/needed]: none
Attachment #8523333 - Flags: approval-mozilla-beta?
Attachment #8523333 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7fe78086ac8a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8523333 [details] [diff] [review]
Patch: Add telemetry for canceling/dismissing the start pane

Approving for both Beta/Aurora due to low risk and high value of gathering the info.
Attachment #8523333 - Flags: approval-mozilla-beta?
Attachment #8523333 - Flags: approval-mozilla-beta+
Attachment #8523333 - Flags: approval-mozilla-aurora?
Attachment #8523333 - Flags: approval-mozilla-aurora+
Verified as fixed in builds:
- 36.0a1 2014-11-25;
- 35.0a2 2014-11-25;
- 34 RC1;
Device: Asus Transformer Tab (Android 4.2.1).
You need to log in before you can comment on or make changes to this bug.