1099462 - Set the Getting Started URL for Loop

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1083466 is using a temporary URL until we get the official one. This bug is to set the official one.

Comment 1

[:shell escalante]

Hi Cory, who should this be assigned to until the URL is determined and Jared is told?

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Hi Shell,

I've assigned this to myself.

Once the parameters from analytics have been set, I will update this bug.

Thank you

Comment 3

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Hi Jared,

Please see below for the "Getting Started" URL.

https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/hello/start?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=doorhanger

Thanks.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks. I've closed bug 1101286 and will handle updating both sources in this bug.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Hi Marco, can you please add this bug to the tracker for 36.3? Thanks!

Comment 7

[Marco Mucci [:MarcoM]]

Added to IT 36.3

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8526430 [details] [diff] [review]
Patch

Review of attachment 8526430 [details] [diff] [review]:
-----------------------------------------------------------------

r=me but I think it would be good to see if Corey wants to change this today.

::: browser/components/loop/content/js/panel.jsx
@@ +165,5 @@
>    });
>  
>    var GettingStartedView = React.createClass({
>      handleButtonClick: function() {
> +      navigator.mozLoop.openGettingStartedTour("doorhanger");

I personally think "doorhanger" is an implementation detail and also confusing since the settings-menu is also in the "doorhanger". I think a better name would be something like "getting-started".

Comment 9

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Hi MattN,

That'll work, thanks!

Comment 10

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Comment on attachment 8526430 [details] [diff] [review]
Patch

Review of attachment 8526430 [details] [diff] [review]:
-----------------------------------------------------------------

"getting-started" would work in place of "doorhanger" for the utm_campaign parameter. Thank you.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Thanks, I'll make the switch before landing.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/bfc68d26c7da

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfc68d26c7da

Comment 14

[u279076]

We won't verify this bug specifically, this bug will be verified in part through testing the meta bug.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8526430 [details] [diff] [review]
Patch

Approval Request Comment
[Risks and why]: Loop rooms code needed for 35 pref-on
[String/UUID change made/needed]: none

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/749a29e73e91