Closed
Bug 1099462
Opened 10 years ago
Closed 9 years ago
Set the Getting Started URL for Loop
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35 fixed, firefox36 fixed)
backlog | Fx35+ |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [FTE][good first verify])
Attachments
(1 file)
5.28 KB,
patch
|
MattN
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 1083466 is using a temporary URL until we get the official one. This bug is to set the official one.
Flags: qe-verify+
Flags: firefox-backlog+
Updated•10 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Comment 1•10 years ago
|
||
Hi Cory, who should this be assigned to until the URL is determined and Jared is told?
Flags: needinfo?(cprice)
Whiteboard: [FTE]
Comment 2•10 years ago
|
||
Hi Shell, I've assigned this to myself. Once the parameters from analytics have been set, I will update this bug. Thank you
Assignee: nobody → cprice
Flags: needinfo?(cprice)
Comment 3•10 years ago
|
||
Hi Jared, Please see below for the "Getting Started" URL. https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/hello/start?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=doorhanger Thanks.
Flags: needinfo?(jaws)
Assignee | ||
Comment 4•10 years ago
|
||
Thanks. I've closed bug 1101286 and will handle updating both sources in this bug.
Assignee: cprice → jaws
Status: NEW → ASSIGNED
Points: 1 → 3
Flags: needinfo?(jaws)
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 36.3
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8526430 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 6•10 years ago
|
||
Hi Marco, can you please add this bug to the tracker for 36.3? Thanks!
Flags: needinfo?(mmucci)
Comment 8•10 years ago
|
||
Comment on attachment 8526430 [details] [diff] [review] Patch Review of attachment 8526430 [details] [diff] [review]: ----------------------------------------------------------------- r=me but I think it would be good to see if Corey wants to change this today. ::: browser/components/loop/content/js/panel.jsx @@ +165,5 @@ > }); > > var GettingStartedView = React.createClass({ > handleButtonClick: function() { > + navigator.mozLoop.openGettingStartedTour("doorhanger"); I personally think "doorhanger" is an implementation detail and also confusing since the settings-menu is also in the "doorhanger". I think a better name would be something like "getting-started".
Attachment #8526430 -
Flags: review?(MattN+bmo)
Attachment #8526430 -
Flags: review+
Attachment #8526430 -
Flags: feedback?(cprice)
Comment 9•10 years ago
|
||
Hi MattN, That'll work, thanks!
Comment 10•10 years ago
|
||
Comment on attachment 8526430 [details] [diff] [review] Patch Review of attachment 8526430 [details] [diff] [review]: ----------------------------------------------------------------- "getting-started" would work in place of "doorhanger" for the utm_campaign parameter. Thank you.
Assignee | ||
Comment 11•10 years ago
|
||
Thanks, I'll make the switch before landing.
Assignee | ||
Updated•10 years ago
|
Attachment #8526430 -
Flags: feedback?(cprice)
Assignee | ||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bfc68d26c7da
Whiteboard: [FTE] → [FTE][fixed-in-fx-team]
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bfc68d26c7da
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [FTE][fixed-in-fx-team] → [FTE]
Target Milestone: --- → mozilla36
Comment 14•9 years ago
|
||
We won't verify this bug specifically, this bug will be verified in part through testing the meta bug.
Comment 15•9 years ago
|
||
Comment on attachment 8526430 [details] [diff] [review] Patch Approval Request Comment [Risks and why]: Loop rooms code needed for 35 pref-on [String/UUID change made/needed]: none
Attachment #8526430 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8526430 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•