Closed Bug 1099495 Opened 10 years ago Closed 10 years ago

Use mozL10n.get instead of mozL10n.get alias in code that already has the alias defined

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla36
Iteration:
36.3
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
8.19 KB, patch
NiKo
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
No description provided.
Flags: firefox-backlog+
Flags: qe-verify?
Attached patch Patch (obsolete) — — Splinter Review
Attachment #8523412 - Flags: review?(nperriault)
Flags: qe-verify? → qe-verify-
iirc I thought we were wanting to move away from the __ as mozL10n.get is more explicit. Hopefully NiKo can remember the discussions there though.
Yeah, that is not surprising. This was the only file that I found that aliased mozL10n.get to __, so removing that alias and becoming consistent with the other files is probably the better route.
Comment on attachment 8523412 [details] [diff] [review] Patch Review of attachment 8523412 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3) > so removing that alias and becoming consistent > with the other files is probably the better route. Exactly this :)
Attachment #8523412 - Flags: review?(nperriault) → review-
Attached patch Patch v2 — — Splinter Review
Attachment #8523412 - Attachment is obsolete: true
Attachment #8523583 - Flags: review?(nperriault)
Summary: Use mozL10n.get alias instead of mozL10n.get in code that already has the alias defined → Use mozL10n.get instead of mozL10n.get alias in code that already has the alias defined
Comment on attachment 8523583 [details] [diff] [review] Patch v2 Review of attachment 8523583 [details] [diff] [review]: ----------------------------------------------------------------- r+ conditional to land the .js version along the .jsx one.
Attachment #8523583 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/mozilla-central/rev/2b6ef0e5d2dd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
status-firefox36: --- → fixed
Comment on attachment 8523583 [details] [diff] [review] Patch v2 Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: more likely to get conflicts, less readable [Describe test coverage new/current, TBPL]: on m-c [Risks and why]: Code cleanup and avoid divergence. Low risk. [String/UUID change made/needed]: none
Attachment #8523583 - Flags: approval-mozilla-aurora?
Attachment #8523583 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: