Closed
Bug 1100169
Opened 10 years ago
Closed 10 years ago
Fix allocation kind computation for inline typed objects
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
InlineTypedObject::allocKindForTypeDescriptor has a misplaced closed paren that causes inline typed objects to be much larger than they need to be. This function was also not updated after bug 1073842 to account for the slimmer size of InlineTypedObjects vs. NativeObjects. On my machine this fixes the AWFY assorted simple-struct-typedobj test so that the TypedObject version is substantially faster than the normal objects version, rather than being twice as slow.
Attachment #8523575 -
Flags: review?(nmatsakis)
|
||
Updated•10 years ago
|
Attachment #8523575 -
Flags: review?(nmatsakis) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/05bd5fb3b1b5
https://hg.mozilla.org/mozilla-central/rev/05bd5fb3b1b5
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•