Closed Bug 1100169 Opened 5 years ago Closed 5 years ago

Fix allocation kind computation for inline typed objects

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
InlineTypedObject::allocKindForTypeDescriptor has a misplaced closed paren that causes inline typed objects to be much larger than they need to be.  This function was also not updated after bug 1073842 to account for the slimmer size of InlineTypedObjects vs. NativeObjects.

On my machine this fixes the AWFY assorted simple-struct-typedobj test so that the TypedObject version is substantially faster than the normal objects version, rather than being twice as slow.
Attachment #8523575 - Flags: review?(nmatsakis)
Attachment #8523575 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/05bd5fb3b1b5
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.