[Keyboard][Handwriting] Add words prediction feature

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wdeng@mozilla.com, Assigned: wdeng@mozilla.com)

Tracking

unspecified
2.2 S2 (19dec)

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Assignee: nobody → wdeng
(Assignee)

Comment 1

3 years ago
Created attachment 8525029 [details] [review]
patch - pull request 26269

Hi Omega,
  This patch is for handwriting worlds prediction, I tried to make its UX the same as Pinyin, can you try it and give me some feedback? Thanks a lot!
Attachment #8525029 - Flags: feedback?(ofeng)
Created attachment 8525115 [details]
Handwriting_Prediciton.pdf

Please see p.2 for UX suggestion.
Attachment #8525029 - Flags: feedback?(ofeng)
(Assignee)

Comment 3

3 years ago
Hi Omega,
  Thank you for your feedback, the new design is almost the same with handwriting IME on IOS, the previous implementation looks like most handwriting IMEs on android.
  Thanks a lot!
(Assignee)

Comment 4

3 years ago
Hi Omega,
  The patch is updated and improved to the new design, can you try it and give me a feedback? Thanks a lot!
Flags: needinfo?(ofeng)
(Assignee)

Updated

3 years ago
Attachment #8525029 - Flags: feedback?(ofeng)
Comment on attachment 8525029 [details] [review]
patch - pull request 26269

Great, it works like what I said.
Thanks a lot!
Flags: needinfo?(ofeng)
Attachment #8525029 - Flags: feedback?(ofeng) → feedback+
(Assignee)

Comment 6

3 years ago
Comment on attachment 8525029 [details] [review]
patch - pull request 26269

Hi Tim,
  The patch implenmented:
  1. The new design from UX team(Omega), and
  2. Added getPrediction API and reformated recognition.js
  3. Added words prediction function in C code engine and translated by emscripten into emscripten_zinnia.js and emscripten_zinnia.data, 
  4. Changed response time range,
  5. According to the new design, clear handwriting pad will be invoked in IME implenmentation, so changed HandwritingPadsManager responsively.
Attachment #8525029 - Flags: feedback+ → feedback?(timdream)
Attachment #8525029 - Flags: feedback?(timdream) → feedback+
(Assignee)

Comment 7

3 years ago
Comment on attachment 8525029 [details] [review]
patch - pull request 26269

Thanks for your review!
Attachment #8525029 - Flags: review?(timdream)
Comment on attachment 8525029 [details] [review]
patch - pull request 26269

See Github for comments.
Attachment #8525029 - Flags: review?(timdream) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/e04ab7651b1e0c67516e1cef7aa4bc6072529885
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
You need to log in before you can comment on or make changes to this bug.