1100232 - startOver() should not delete FxA credentials

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

As part of Service.startOver(), we call identity.deleteSyncCredentials() - this deletes both the legacy and FxA credentials from the login manager.

This is a problem for sync migration as we log the user into FxA *before* we call .startOver() - this means the credentials we just saved to the login manager are removed and the user will need to re-authenticate next start.

The fix will be to have a different deleteSyncCredentials() for each of the 2 identity implementations and have each one delete only its credentials.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0010-Bug-1100232-startOver-should-not-delete-FxA-credenti.patch

This creates 2 new functions, getSyncCredentialsHostsLegacy and getSyncCredentialsHostsFxA.  getSyncCredentialsHosts() returns the combined value of these 2 functions, however, the identity function deleteSyncCredentials() now only deletes the credentials related to that specific identity.  This means that on a .startOver() the FxA credentials remain in the login manager.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8526557 [details] [diff] [review]
0010-Bug-1100232-startOver-should-not-delete-FxA-credenti.patch

Review of attachment 8526557 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delayed review!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/9acf9c028045

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9acf9c028045