[Stingray] Allow appdeck or other certified apps to take screenshot

RESOLVED FIXED in 2.1 S9 (21Nov)

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rexboy, Assigned: rexboy)

Tracking

unspecified
2.1 S9 (21Nov)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 attachments)

For pin-to-card use case, apps need to get screenshots for themselves. This can be realized by system app but not possible for apps for now. So this bug is dedicated for opening a way to let app get screenshots from system app.
Assignee: nobody → rexboy
Created attachment 8523800 [details]
Patch

John may you give some feedback on this patch?
I temporarily let Home App use the screen capturing, but it should actually be landed into AppDeck and other apps.
Attachment #8523800 - Flags: feedback?(im)
Comment on attachment 8523800 [details]
Patch

This looks good for our short-term milestone. In the future, we may still need to support screenshot on "OOP" case. I would like to see the current version. And we add the OOP support when we need it.

Another issue is that we should keep this activity as certified only. I don't know if we can do it or not. If not, we should change to IAC.
Attachment #8523800 - Flags: feedback?(im)

Updated

4 years ago
Target Milestone: --- → 2.1 S9 (21Nov)
Created attachment 8525791 [details] [review]
patch

John would you help review this patch?
Attachment #8525791 - Flags: review?(im)
In this version I changed the implementation to IAC for limiting permission to certified apps.
Comment on attachment 8525791 [details] [review]
patch

Bascially, the code is workable and looks good, except sending blob. So, I give r+ but please check the following before landing the code.

I do not have enough knowledge about IAC sending Blob. In my previous experience, all large object sending through MessagePort should be wrapped with Transferable. That can ease the usage of memory. But I am not really sure about this in IAC.
Attachment #8525791 - Flags: review?(im) → review+
By the study with John we found that IAC port hasn't support Transferable objects yet. So I'll keep the code as is for now.
https://github.com/mozilla-b2g/gaia/commit/d1a32413537a9e0b61a78377b3dfbd5b6e82c15d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.