1100238 - [Stingray] Allow appdeck or other certified apps to take screenshot

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

For pin-to-card use case, apps need to get screenshots for themselves. This can be realized by system app but not possible for apps for now. So this bug is dedicated for opening a way to let app get screenshots from system app.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP
https://github.com/rexboy7/gaia/commit/f86a6bd7c978e78e8a657a784a3d7ca5d7070442

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Patch

John may you give some feedback on this patch?
I temporarily let Home App use the screen capturing, but it should actually be landed into AppDeck and other apps.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8523800 [details]
Patch

This looks good for our short-term milestone. In the future, we may still need to support screenshot on "OOP" case. I would like to see the current version. And we add the OOP support when we need it.

Another issue is that we should keep this activity as certified only. I don't know if we can do it or not. If not, we should change to IAC.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

John would you help review this patch?

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

In this version I changed the implementation to IAC for limiting permission to certified apps.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8525791 [details] [review]
patch

Bascially, the code is workable and looks good, except sending blob. So, I give r+ but please check the following before landing the code.

I do not have enough knowledge about IAC sending Blob. In my previous experience, all large object sending through MessagePort should be wrapped with Transferable. That can ease the usage of memory. But I am not really sure about this in IAC.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

By the study with John we found that IAC port hasn't support Transferable objects yet. So I'll keep the code as is for now.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/d1a32413537a9e0b61a78377b3dfbd5b6e82c15d