Remove $cookies and localStorage from dependency injection where not needed

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

(Blocks: 1 bug, {perf})

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The firefox profiler says that we are treeherder-ui is spending ~7-10% of the time checking the content of the cookies. We can completely remove $cookies and localStorage from the dependency injection because they're not used anywhere
(Assignee)

Updated

3 years ago
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8523826 [details] [review]
Github PR #272 on treeherder-ui
Attachment #8523826 - Flags: review?(emorley)

Comment 2

3 years ago
Comment on attachment 8523826 [details] [review]
Github PR #272 on treeherder-ui

lgtm - please can you add the bug number to the commit message before landing.
Yey for cleanup :-)
Attachment #8523826 - Flags: review?(emorley) → review+

Updated

3 years ago
Blocks: 1067846
Keywords: perf
(Assignee)

Comment 3

3 years ago
Oh yeah, sure, I forgot :p

Comment 4

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/6d2b82e81878212322a57d4c2473dfe82c588b65
Bug 1100328 - remove $cookies and localStorage from dependency

injection where not needed
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 1059400

Comment 5

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/31c6859c1285fd321991e4672ead3eb70a4a1c3f
Bug 1100328 - remove $cookies and localStorage from dependency

injection where not needed
You need to log in before you can comment on or make changes to this bug.