Closed
Bug 1100328
Opened 10 years ago
Closed 10 years ago
Remove $cookies and localStorage from dependency injection where not needed
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdoglio, Assigned: mdoglio)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
The firefox profiler says that we are treeherder-ui is spending ~7-10% of the time checking the content of the cookies. We can completely remove $cookies and localStorage from the dependency injection because they're not used anywhere
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mdoglio
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8523826 -
Flags: review?(emorley)
Comment 2•10 years ago
|
||
Comment on attachment 8523826 [details] [review]
Github PR #272 on treeherder-ui
lgtm - please can you add the bug number to the commit message before landing.
Yey for cleanup :-)
Attachment #8523826 -
Flags: review?(emorley) → review+
Updated•10 years ago
|
Assignee | ||
Comment 3•10 years ago
|
||
Oh yeah, sure, I forgot :p
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/6d2b82e81878212322a57d4c2473dfe82c588b65
Bug 1100328 - remove $cookies and localStorage from dependency
injection where not needed
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Blocks: treeherder-dev-transition
Comment 5•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/31c6859c1285fd321991e4672ead3eb70a4a1c3f
Bug 1100328 - remove $cookies and localStorage from dependency
injection where not needed
You need to log in
before you can comment on or make changes to this bug.
Description
•