1100345 - Unable to run Gij with Mulet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[:gerard-majax]

> make test-integration-test RUNTIME=/home/alex/codaz/Mozilla/b2g/gecko/obj-mulet/dist/firefox/firefox

Mulet starts, Gaia is visible, but tests are not started. I know this used to work ...

Comment 1

[:gerard-majax]

Johnathan, are you aware of changes that may have broke us? I'm unable to find anything, and I see no error whatsoever :(

Comment 2

[Jonathan Griffin (:jgriffin)]

I don't know; I'll cc a couple of folks on the B2G automation team to see if they have ideas.

Comment 3

[James Lal [:lightsofapollo]]

Putting this in my queue... I think we may have regressed this recently (though it will be way easier now to use this)

Comment 4

[:gerard-majax]

Ok, we still need:

diff --git a/testing/marionette/marionette-server.js b/testing/marionette/marionette-server.js
index e8e5448..521890a 100644
--- a/testing/marionette/marionette-server.js
+++ b/testing/marionette/marionette-server.js
@@ -38,7 +38,7 @@ Cu.import("resource://gre/modules/FileUtils.jsm");
 Cu.import("resource://gre/modules/NetUtil.jsm");
 
 Services.prefs.setBoolPref("marionette.contentListener", false);
-let appName = Services.appinfo.name;
+let appName = "B2G"; // Services.appinfo.name;
 
 let { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
 let DevToolsUtils = devtools.require("devtools/toolkit/DevToolsUtils.js");

Comment 5

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin

Comment 6

[:gerard-majax]

https://tbpl.mozilla.org/?tree=Try&rev=6ceb886c4dd0

Comment 7

[:gerard-majax]

Comment on attachment 8526779 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

That's a first tentative, but I'm not very convinced by myself:
 - hardcoding "B2G", but I don't see any other way
 - maybe we should make isMulet part of Services.jsm?
 - maybe we should have a mulet-specific pref also, rather than lurking around the startup homepage ?

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8526779 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Review of attachment 8526779 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but can you also remove the code that used to do this from http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2920 ?

Comment 9

[Jonathan Griffin (:jgriffin)]

(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Comment on attachment 8526779 [details] [diff] [review]
> Make Mulet appear as B2G for Marionette r=jgriffin
> 
> That's a first tentative, but I'm not very convinced by myself:
>  - hardcoding "B2G", but I don't see any other way
>  - maybe we should make isMulet part of Services.jsm?
>  - maybe we should have a mulet-specific pref also, rather than lurking
> around the startup homepage ?

Marionette has to behave differently for Mulet depending on whether or not it's running Gaia.  We could go the pref route, if that pref were only set for the Gaia case.

Comment 10

[:gerard-majax]

(In reply to Jonathan Griffin (:jgriffin) from comment #8)
> Comment on attachment 8526779 [details] [diff] [review]
> Make Mulet appear as B2G for Marionette r=jgriffin
> 
> Review of attachment 8526779 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, but can you also remove the code that used to do this from
> http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-
> server.js#2920 ?

Thanks, I missed this one.

Comment 11

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin

Comment 12

[:gerard-majax]

Comment on attachment 8527285 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Updated all places, and moved to Services.isMulet

Comment 13

[:gerard-majax]

Pending try: https://tbpl.mozilla.org/?tree=Try&rev=60fa803a0f29

Comment 14

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin

Comment 15

[:gerard-majax]

Made a small typo that broke Marionnette. New try: https://tbpl.mozilla.org/?tree=Try&rev=1d2dc1046862

Comment 16

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin

Comment 17

[:gerard-majax]

Comment on attachment 8527293 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Let's keep this as simple as possible.

Comment 18

[:gerard-majax]

New try: https://tbpl.mozilla.org/?tree=Try&rev=17ab987b2f6d

Comment 19

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #18)
> New try: https://tbpl.mozilla.org/?tree=Try&rev=17ab987b2f6d

So the only red on this is B2G ICS Emulator Opt Mn, and it was red before my changes.

Comment 20

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8527293 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Review of attachment 8527293 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, nice solution, thanks.

Comment 21

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin,gavin

Comment 22

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8528290 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin

Services.jsm is not the right place for this - "isMulet" is not a service. Couldn't the marionette-server code just check for a Mulet-only pref instead?

Comment 23

[:gerard-majax]

Sure, this is what I was not sure about in comment 7, I'll update with a pref then :)

Comment 24

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin,gavin

When running Gaia Marionette integration tests, we need to talk to Mulet
like if it was a B2G device. We define the "b2g.is_mulet" pref for this
purpose.

Comment 25

[:gerard-majax]

Try with the new pref: https://tbpl.mozilla.org/?tree=Try&rev=ccade8fbcd58

Comment 26

[:gerard-majax]

Looks greenish: https://tbpl.mozilla.org/?tree=Try&rev=ccade8fbcd58

Comment 27

[:gerard-majax]

Comment on attachment 8529527 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin

Carrying r+ from :jgriffin

Comment 28

[:gerard-majax]

Attachment: Make Mulet appear as B2G for Marionette r=jgriffin

When running Gaia Marionette integration tests, we need to talk to Mulet
like if it was a B2G device. We define the "b2g.is_mulet" pref for this
purpose.

Comment 29

[:gerard-majax]

Comment on attachment 8529695 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Pref only solution, as advised by :gavin.

Comment 30

[:gerard-majax]

New try: https://tbpl.mozilla.org/?tree=Try&rev=0e0686690534

Comment 31

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/220e9759efe8

Comment 32

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/220e9759efe8