Unable to run Gij with Mulet

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 6 obsolete attachments)

(Assignee)

Description

4 years ago
> make test-integration-test RUNTIME=/home/alex/codaz/Mozilla/b2g/gecko/obj-mulet/dist/firefox/firefox

Mulet starts, Gaia is visible, but tests are not started. I know this used to work ...
(Assignee)

Updated

4 years ago
Blocks: 1035226
(Assignee)

Comment 1

4 years ago
Johnathan, are you aware of changes that may have broke us? I'm unable to find anything, and I see no error whatsoever :(
Flags: needinfo?(jgriffin)
I don't know; I'll cc a couple of folks on the B2G automation team to see if they have ideas.
Flags: needinfo?(mdas)
Flags: needinfo?(jlal)
Flags: needinfo?(jgriffin)
Putting this in my queue... I think we may have regressed this recently (though it will be way easier now to use this)
Assignee: nobody → jlal
Status: NEW → ASSIGNED
Flags: needinfo?(mdas)
Flags: needinfo?(jlal)
(Assignee)

Comment 4

4 years ago
Ok, we still need:

diff --git a/testing/marionette/marionette-server.js b/testing/marionette/marionette-server.js
index e8e5448..521890a 100644
--- a/testing/marionette/marionette-server.js
+++ b/testing/marionette/marionette-server.js
@@ -38,7 +38,7 @@ Cu.import("resource://gre/modules/FileUtils.jsm");
 Cu.import("resource://gre/modules/NetUtil.jsm");
 
 Services.prefs.setBoolPref("marionette.contentListener", false);
-let appName = Services.appinfo.name;
+let appName = "B2G"; // Services.appinfo.name;
 
 let { devtools } = Cu.import("resource://gre/modules/devtools/Loader.jsm", {});
 let DevToolsUtils = devtools.require("devtools/toolkit/DevToolsUtils.js");
(Assignee)

Comment 5

4 years ago
Created attachment 8526779 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin
(Assignee)

Comment 7

4 years ago
Comment on attachment 8526779 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

That's a first tentative, but I'm not very convinced by myself:
 - hardcoding "B2G", but I don't see any other way
 - maybe we should make isMulet part of Services.jsm?
 - maybe we should have a mulet-specific pref also, rather than lurking around the startup homepage ?
Attachment #8526779 - Flags: feedback?(jgriffin)
Comment on attachment 8526779 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Review of attachment 8526779 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but can you also remove the code that used to do this from http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2920 ?
Attachment #8526779 - Flags: feedback?(jgriffin) → feedback+
(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Comment on attachment 8526779 [details] [diff] [review]
> Make Mulet appear as B2G for Marionette r=jgriffin
> 
> That's a first tentative, but I'm not very convinced by myself:
>  - hardcoding "B2G", but I don't see any other way
>  - maybe we should make isMulet part of Services.jsm?
>  - maybe we should have a mulet-specific pref also, rather than lurking
> around the startup homepage ?

Marionette has to behave differently for Mulet depending on whether or not it's running Gaia.  We could go the pref route, if that pref were only set for the Gaia case.
(Assignee)

Comment 10

4 years ago
(In reply to Jonathan Griffin (:jgriffin) from comment #8)
> Comment on attachment 8526779 [details] [diff] [review]
> Make Mulet appear as B2G for Marionette r=jgriffin
> 
> Review of attachment 8526779 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, but can you also remove the code that used to do this from
> http://dxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-
> server.js#2920 ?

Thanks, I missed this one.
(Assignee)

Comment 11

4 years ago
Created attachment 8527285 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin
(Assignee)

Comment 12

4 years ago
Comment on attachment 8527285 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Updated all places, and moved to Services.isMulet
Attachment #8527285 - Flags: feedback?(jgriffin)
(Assignee)

Updated

4 years ago
Attachment #8526779 - Attachment is obsolete: true
(Assignee)

Comment 14

4 years ago
Created attachment 8527287 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin
(Assignee)

Updated

4 years ago
Attachment #8527285 - Attachment is obsolete: true
Attachment #8527285 - Flags: feedback?(jgriffin)
(Assignee)

Updated

4 years ago
Attachment #8527287 - Flags: feedback?(jgriffin)
(Assignee)

Comment 15

4 years ago
Made a small typo that broke Marionnette. New try: https://tbpl.mozilla.org/?tree=Try&rev=1d2dc1046862
(Assignee)

Comment 16

4 years ago
Created attachment 8527293 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin
(Assignee)

Comment 17

4 years ago
Comment on attachment 8527293 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Let's keep this as simple as possible.
Attachment #8527293 - Flags: feedback?(jgriffin)
(Assignee)

Updated

4 years ago
Attachment #8527287 - Attachment is obsolete: true
Attachment #8527287 - Flags: feedback?(jgriffin)
(Assignee)

Comment 19

4 years ago
(In reply to Alexandre LISSY :gerard-majax from comment #18)
> New try: https://tbpl.mozilla.org/?tree=Try&rev=17ab987b2f6d

So the only red on this is B2G ICS Emulator Opt Mn, and it was red before my changes.
Comment on attachment 8527293 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Review of attachment 8527293 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, nice solution, thanks.
Attachment #8527293 - Flags: feedback?(jgriffin) → feedback+
(Assignee)

Updated

4 years ago
Attachment #8527293 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Assignee: jlal → lissyx+mozillians
(Assignee)

Comment 21

4 years ago
Created attachment 8528290 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin
(Assignee)

Updated

4 years ago
Attachment #8528290 - Flags: review?(jgriffin)
Attachment #8528290 - Flags: review?(gavin.sharp)
(Assignee)

Updated

4 years ago
Blocks: 1104644
Attachment #8528290 - Flags: review?(jgriffin) → review+
Comment on attachment 8528290 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin

Services.jsm is not the right place for this - "isMulet" is not a service. Couldn't the marionette-server code just check for a Mulet-only pref instead?
Attachment #8528290 - Flags: review?(gavin.sharp) → review-
(Assignee)

Comment 23

4 years ago
Sure, this is what I was not sure about in comment 7, I'll update with a pref then :)
(Assignee)

Comment 24

4 years ago
Created attachment 8529527 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin

When running Gaia Marionette integration tests, we need to talk to Mulet
like if it was a B2G device. We define the "b2g.is_mulet" pref for this
purpose.
(Assignee)

Comment 27

4 years ago
Comment on attachment 8529527 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin,gavin

Carrying r+ from :jgriffin
Attachment #8529527 - Flags: review+
(Assignee)

Comment 28

4 years ago
Created attachment 8529695 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

When running Gaia Marionette integration tests, we need to talk to Mulet
like if it was a B2G device. We define the "b2g.is_mulet" pref for this
purpose.
(Assignee)

Updated

4 years ago
Attachment #8529527 - Attachment is obsolete: true
(Assignee)

Comment 29

4 years ago
Comment on attachment 8529695 [details] [diff] [review]
Make Mulet appear as B2G for Marionette r=jgriffin

Pref only solution, as advised by :gavin.
Attachment #8529695 - Flags: review?(jgriffin)
Attachment #8529695 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

4 years ago
Attachment #8528290 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/220e9759efe8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.