1100352 - Remove hard-coded allow lists from ProcessedCrash and RawCrash models

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[[DEACTIVATED] Adrian Gaudebert]

We should rely on our Super Search Fields list and remove the hard-coded white lists of fields in our ProcessedCrash and RawCrash models. However, before doing so, we need to audit our current list to make sure no field was forgotten, so that we don't accidentally remove fields from exposure in our public API.

Comment 1

[Issei Horie [:is2ei]]

Does this issue require just removing the white lists in ProcessedCrash and RawCrash models?
If so, could I work on this issue? It seems relatively easy.

https://github.com/mozilla-services/socorro/blob/e3263f0f678c481017289d92188b0daa8b4a0fe4/webapp-django/crashstats/crashstats/models.py#L605-L654

https://github.com/mozilla-services/socorro/blob/e3263f0f678c481017289d92188b0daa8b4a0fe4/webapp-django/crashstats/crashstats/models.py#L721-L794

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Issei: At some point, I want to tackle this, but not quiet, yet. I think this requires some careful architecture work before we can make code changes.

Comment 3

[Issei Horie [:is2ei]]

Thanks for your comment, Will!
I see. I'll find another issue to work on.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I removed the allow list for the ProcessedCrash API in 683ef8d2.

Still have to do the RawCrash API.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to do soon.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

The allow list for the RawCrash API was removed in adda44e8.

All done here!