1100368 - css concatenation breaks data: urls

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

using a data: url in css while css concatenation is enabled results in a broken url.

background: #c8c8c8 url("data:image/gif;base64,R0lGODlhKAAoAIAB..");}

becomes

background: #c8c8c8 url(../../skins/contrib/Dusk/data:image/gif;base64,R0lGODlhKAAoAIAB..");}

Comment 1

[:glob ✱]

Attachment: 1100368_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8523869 [details] [diff] [review]
1100368_1.patch

Review of attachment 8523869 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

::: Bugzilla/Template.pm
@@ +542,5 @@
>      # directory from the source
>      $url =~ s/(^['"]|['"]$)//g;
> +    if (substr($url, 0, 1) eq '/' || substr($url, 0, 5) eq 'data:') {
> +        return 'url(' . $url . ')';
> +    }

Not that it matters here, but a regex is faster at not-matching than the above construction. (and the above is faster in the case of matching input).

Comment 3

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   2e000da..f43045d  5.0 -> 5.0

To ssh://[e-mail]/bugzilla/bugzilla.git
   a50e8fd..47da91d  master -> master