Closed Bug 1100451 Opened 10 years ago Closed 10 years ago

Don't re-create bugjobmap and classification objects in the annotations plugin controller

Categories

(Tree Management :: Treeherder, defect)

Product:
Tree Management
Component:
Treeherder
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mdoglio, Assigned: mdoglio)

Details

Attachments

(1 file)

Github PR #273 on treeherder-ui
49 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
I think these two objects don't need to be re-created: https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/annotations/controller.js#L24 https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/annotations/controller.js#L45 Whatever comes down the wire through a ThBugJobMapModel or ThJobClassificationModel gets automatically their behaviour.
Assignee: nobody → mdoglio
Attachment #8524562 - Flags: review?(emorley)
Status: NEW → ASSIGNED
Attachment #8524562 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/5bf3fadba4027ea613e9799a3c93177dfda3cb06 Bug 1100451 - Don't re-create bugjobmap and classification objects in the annotations plugin controller
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/7342bd9f7523efe29d7fe91ca326938f92e458bb Bug 1100451 - Don't re-create bugjobmap and classification objects in the annotations plugin controller
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: