1100664 - Fix browser_minimize.js to not try to access content docshells sync (because e10s)

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (out for now; he/him)]

This test was written for bug 648045, which needs to ensure that selected content docshells are marked inactive when the browser is minimized.

Understandably, it tries to use gBrowser.docShell, which is really gBrowser.mCurrentBrowser.docShell, which doesn't work in e10s. Predictable sadness ensues.

Comment 1

[:Gijs (out for now; he/him)]

browser_tabs_isActive.js has the same issue:


function tabIsActive(tab) {
  let browser = tab.linkedBrowser;
  return browser.docShell.isActive;
}

which breaks because of the same reasons.

Comment 2

[Chris Peterson [:cpeterson]]

e10s test bugs should block tracking-e10s=+

Comment 3

[Tracy Walker [:tracy]]

I'll take a look at fixing this test case.

Comment 4

[Tracy Walker [:tracy]]

Attachment: Patch for 1100664

Patch attached for updating browser/base/content/test/general/browser_minimize.js.  Try run, https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df11165a6ac, passed. 

Note: /browser/base/content/test/general/browser_tabs_isActive.js was updated in bug 1199765 when jim added e10s support for querying of active state.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2d6b8d33e11

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2d6b8d33e11

Comment 7

[Tracy Walker [:tracy]]

Jim and I both failed to remove skip-if = e10s in the browser.ini for browser_minimize.js and browser_tabs_isActive.js

Comment 8

[Tracy Walker [:tracy]]

Attachment: browser-ini.patch

attaching a patch to enable the test cases

try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=6116c237e0ba passed

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8671976 [details] [diff] [review]
browser-ini.patch

thanks!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7745c2bdb0ab

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7745c2bdb0ab