Closed Bug 1100664 Opened 5 years ago Closed 4 years ago

Fix browser_minimize.js to not try to access content docshells sync (because e10s)

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
e10s + ---
firefox44 --- fixed

People

(Reporter: Gijs, Assigned: tracy)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This test was written for bug 648045, which needs to ensure that selected content docshells are marked inactive when the browser is minimized.

Understandably, it tries to use gBrowser.docShell, which is really gBrowser.mCurrentBrowser.docShell, which doesn't work in e10s. Predictable sadness ensues.
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
Summary: Fix browser_minimize.js to not try to access content docshells sync → Fix browser_minimize.js to not try to access content docshells sync (because e10s)
browser_tabs_isActive.js has the same issue:


function tabIsActive(tab) {
  let browser = tab.linkedBrowser;
  return browser.docShell.isActive;
}

which breaks because of the same reasons.
Summary: Fix browser_minimize.js to not try to access content docshells sync (because e10s) → Fix browser_minimize.js and browser_tabs_isActive.js to not try to access content docshells sync (because e10s)
e10s test bugs should block tracking-e10s=+
I'll take a look at fixing this test case.
Assignee: nobody → twalker
Depends on: 1199765
Attached patch Patch for 1100664 (obsolete) — Splinter Review
Patch attached for updating browser/base/content/test/general/browser_minimize.js.  Try run, https://treeherder.mozilla.org/#/jobs?repo=try&revision=8df11165a6ac, passed. 

Note: /browser/base/content/test/general/browser_tabs_isActive.js was updated in bug 1199765 when jim added e10s support for querying of active state.
Attachment #8670208 - Flags: review?(jmathies)
Attachment #8670208 - Flags: review?(jmathies) → review+
Keywords: checkin-needed
Summary: Fix browser_minimize.js and browser_tabs_isActive.js to not try to access content docshells sync (because e10s) → Fix browser_minimize.js to not try to access content docshells sync (because e10s)
https://hg.mozilla.org/mozilla-central/rev/a2d6b8d33e11
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Jim and I both failed to remove skip-if = e10s in the browser.ini for browser_minimize.js and browser_tabs_isActive.js
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
attaching a patch to enable the test cases

try run https://treeherder.mozilla.org/#/jobs?repo=try&revision=6116c237e0ba passed
Attachment #8671976 - Flags: review?(jmathies)
Comment on attachment 8671976 [details] [diff] [review]
browser-ini.patch

thanks!
Attachment #8671976 - Flags: review?(jmathies) → review+
Keywords: checkin-needed
Attachment #8670208 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7745c2bdb0ab
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.