1100670 - Port |Bug 990799 - Update search plugins to use rel="searchform"| to SeaMonkey

Status: ASSIGNED

(SeaMonkey :: Search, defect)

Description

[Ian Neal]

Attachment: Move rel="searchform"

Bug 990799 added rel="searchform" to the search engine rather than as a separate entry, those changes should be reflected in SeaMonkey.

Comment 1

[[e-mail]]

Comment on attachment 8524172 [details] [diff] [review]
Move rel="searchform"

>-<Url type="text/html" method="GET" template="https://www.google.com/search">
>+<Url type="text/html"
>+     method="GET"
>+     template="https://www.google.com/search"
>+     rel="searchform">
>   <Param name="q" value="{searchTerms}"/>
>   <Param name="ie" value="utf-8"/>
>   <Param name="oe" value="utf-8"/>
>   <Param name="aq" value="t"/>
>   <!-- Dynamic parameters -->
>   <Param name="rls" value="{moz:distributionID}:{moz:locale}:{moz:official}"/>
>   <MozParam name="client" condition="defaultEngine" trueValue="seamonkey-a" falseValue="seamonkey"/>
> </Url>
>-<Url type="text/html"
>-     method="GET"
>-     template="https://www.google.com/"
>-     rel="searchform"/>
> </SearchPlugin>
Sorry, but I don't like the way that this changes the URLs that an "empty" search (e.g. Ctrl+Shift+S with no search bar) uses, e.g. it no longer goes to google.co.uk; is this expected?

Comment 2

[Philip Chee]

> Sorry, but I don't like the way that this changes the URLs that an "empty"
> search (e.g. Ctrl+Shift+S with no search bar) uses, e.g. it no longer goes
> to google.co.uk; is this expected?
IanN wanted me to use rel=searchform for the duckduckgo searchengine so I dug around devmo (woefully out of date) and bugzilla.
What I *think* happens is that:
1. <searchForm> takes priority. If it doesn't exist
2. look for rel="searchform" and take the (complete) template as the searchform URL. If this doesn't exist:
3. Take the url from the template of the <Url type="text/html ...> and extract the prepath as the searchform.

So for e.g. eBay you need a separate <SearchForm>.