1100740 - [settings] refactor Device more info panel with AMD pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

As comment in bug 973450 comment 11,

will provide about_more_info panel refactor here

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

WIP, need port test cases

Comment 2

[[e-mail]]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

basic test cases added. 

I'd like to get feedback which parts should also be tested for this sub panel.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

Left some comments on github. Basically this patch looks good to me, thanks Fred :)

Comment 4

[[e-mail]]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

sync to current code base, please kindly review it

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

Fred, I think these are final comments that needs to be addressed. Please check my comments on github, thanks !

Comment 6

[[e-mail]]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

comment addressed, please kindly review it again!

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8524332 [details] [review]
pull request redirect to github

r+ with last nit waiting to be addressed.

Thanks Fred !!!

Comment 8

[[e-mail]]

thanks for review!

Let's try autoland \o/

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5ad3479659ebaac27c76d827f0fb20a8896dbfc5