1100789 - [NFC] Shrinking should not tilt while utility tray is active

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

We should prevent shrinking while utility tray is active.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8524524 [details] [review]
PR to master

Hi Alive,
could you review it for me?
As discussed with Juwei, we would like to disable shrinking while utility tray is active and shown.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8524524 [details] [review]
PR to master

Use Service.query('getTopMostUI') === self instead of adding A.active && B.active && C.active .... in the module

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8524524 [details] [review]
PR to master

Thanks for advice, Service.query is much more convenient!
could you check it again? Thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8524524 [details] [review]
PR to master

r+ with nit, thanks!

Comment 6

[Gregor Wagner [:gwagner]]

Do we still need this?

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

master: https://github.com/mozilla-b2g/gaia/commit/6acecef3b66378b452c40380a6cf03b361237b3f