Closed Bug 1100917 Opened 6 years ago Closed 6 years ago

Add SSL3/RC4 only server to ssltunnel

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

This is needed to write a test for bug 1092835.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8525314 - Flags: review?(ted)
Comment on attachment 8525314 [details] [diff] [review]
Add config options for SSL3/RC4 only servers to ssltunnel

Review of attachment 8525314 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtests.py
@@ +883,5 @@
>                       (loc.host, loc.port, self.sslPort, redirhost))
>  
> +      if option == "ssl3":
> +        config.write("ssl3:%s:%s:%s\n" % (loc.host, loc.port, self.sslPort))
> +      if option == "rc4":

You could combine these two and just do:
if option in ('ssl3', 'rc4'):
  	
config.write("%s:%s:%s:%s\n" % (option, loc.host, loc.port, self.sslPort))

::: testing/mochitest/ssltunnel/ssltunnel.cpp
@@ +1316,5 @@
> +      LOG_ERROR(("Server on port %d for redirhost option is not defined, use 'listen' option first", port));
> +      return 1;
> +    }
> +
> +    return 0;

It feels like you could combine these two into a single function and just pass the hashtable into it.
Attachment #8525314 - Flags: review?(ted) → review+
Landed with review comments addressed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e415846b951
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/5e415846b951
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.