Closed
Bug 1101031
Opened 11 years ago
Closed 11 years ago
Handle crashes in update service
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: jchen, Assigned: jchen)
Details
Attachments
(1 file, 1 obsolete file)
5.90 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Catch update service crashes using the new crash handler.
Attachment #8524717 -
Flags: review?(snorp)
Comment 2•11 years ago
|
||
Comment on attachment 8524717 [details] [diff] [review]
Report UpdateService crashes (v1)
Review of attachment 8524717 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/updater/UpdateService.java
@@ +89,5 @@
> }
>
> @Override
> public void onCreate () {
> + mCrashHandler = new CrashHandler(Thread.currentThread(), getApplicationContext()) {
This seems like a lot of code, none of which is specific to the update service. Could you factor it out into some common CreateCrashHandler(this) type of method?
Attachment #8524717 -
Flags: review?(snorp)
Assignee | ||
Comment 3•11 years ago
|
||
Added a method in UpdateService to create a generic crash handler.
Attachment #8524717 -
Attachment is obsolete: true
Attachment #8526973 -
Flags: review?(snorp)
Comment 4•11 years ago
|
||
Comment on attachment 8526973 [details] [diff] [review]
Report UpdateService crashes (v2)
Review of attachment 8526973 [details] [diff] [review]:
-----------------------------------------------------------------
That's perfect, thanks
Attachment #8526973 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•