1101031 - Handle crashes in update service

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Report UpdateService crashes (v1)

Catch update service crashes using the new crash handler.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8524717 [details] [diff] [review]
Report UpdateService crashes (v1)

Review of attachment 8524717 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/updater/UpdateService.java
@@ +89,5 @@
>      }
>  
>      @Override
>      public void onCreate () {
> +        mCrashHandler = new CrashHandler(Thread.currentThread(), getApplicationContext()) {

This seems like a lot of code, none of which is specific to the update service. Could you factor it out into some common CreateCrashHandler(this) type of method?

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Report UpdateService crashes (v2)

Added a method in UpdateService to create a generic crash handler.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8526973 [details] [diff] [review]
Report UpdateService crashes (v2)

Review of attachment 8526973 [details] [diff] [review]:
-----------------------------------------------------------------

That's perfect, thanks

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://tbpl.mozilla.org/?tree=Try&rev=a574f10a0327

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/a0664ef9c64f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0664ef9c64f