1101036 - mozilla_buildtools.test.test_build_versions.TestBumpFile failing with AssertionError: '1.1.2pre' != '1.1.3pre'

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

Since we enabled travis testing in bug 1073553, we are getting this one test failure in tools repo:

https://travis-ci.org/mozilla/build-tools/builds/41382779

======================================================================

FAIL: testBumpDefaultVersionTxt (mozilla_buildtools.test.test_build_versions.TestBumpFile)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/build/mozilla/build-tools/lib/python/mozilla_buildtools/test/test_build_versions.py", line 214, in testBumpDefaultVersionTxt

self._doTest("default-version.txt", "1.1.2pre", "1.1.3pre", "1.1.3pre")

File "/home/travis/build/mozilla/build-tools/lib/python/mozilla_buildtools/test/test_build_versions.py", line 192, in _doTest

self.assertEquals(newContents, expectedContents)

AssertionError: '1.1.2pre' != '1.1.3pre'

----------------------------------------------------------------------

Would be good to fix this.

For some reason we don't get it in Jenkins. Not sure why.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: fix test

I'm guessing that this test only ever passed because this regex:
 '^.*(version.*\.txt|milestone\.txt)$': '^%(version)s$',

matches default-version.txt. And I guess we matched with that one first on Jenkins, but Travis is executing in a different order.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: remove default-version.txt

I dug and I dug and I couldn't find any evidence that we've ever bumped a file called "default-version.txt". bug 575400 is where this code originally landed, and the configs with bump files don't list it, so I'm pretty confident this is killable code. It doesn't fix the root issue that if you have files that match more than one regex in BUMP_FILES you can get intermittent behaviour, but this should be fine for now - I added a note about this behaviour.

Comment 3

[Pete Moore [:pmoore][:pete]]

Awesome Ben, thanks for looking into this and fixing so quickly!