Closed Bug 1101387 Opened 6 years ago Closed 5 years ago

[Build] New makefile target to create the "gaia.zip"

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S11 (1may)

People

(Reporter: askeing, Assigned: gduan)

References

Details

Attachments

(1 file, 1 obsolete file)

46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review
Need a new makefile target to create the "gaia.zip".
The files, which have to flash into device, should be compressed into this "gaia.zip"

ex:
gaia.zip
├─ gaia
│   └─ profile
│       ├─ xxx
│       └─ xxx
└─ gonk
    └─ system
        └─ fonts
            └─ hidden
                ├─ gaia-icons.ttf
                └─ Keyboard-Symbols.ttf
Blocks: 1101388
Flags: needinfo?(gduan)
Assignee: nobody → gduan
Flags: needinfo?(gduan)
Comment on attachment 8586713 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

Hi,
Please check if it has fulfilled your requirement.
Thanks.
Attachment #8586713 - Flags: feedback?(fyen)
Attachment #8586713 - Flags: feedback?(fyen) → feedback+
Comment on attachment 8586713 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

Hi Ricky,
could you review this patch? Thanks.
Attachment #8586713 - Flags: review?(ricky060709)
Comment on attachment 8586713 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

Nice job! r=me 
I didn't see any potential problem in this patch.
Attachment #8586713 - Flags: review?(ricky060709) → review+
Thanks,
https://github.com/mozilla-b2g/gaia/commit/5b92d98d2ca9f96a54e8b1b45db93bd15ae04dbe
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Reverted for causing Gbu failures as seen in the gaia-try run, and as seen here: https://treeherder.mozilla.org/#/jobs?repo=gaia-master&revision=5b92d98d2ca9f96a54e8b1b45db93bd15ae04dbe

Revert: https://github.com/mozilla-b2g/gaia/commit/7e3fe905838438949c6bc108a7971ce4972b0115

I recommend landing using checkin-needed and autolander in the future to prevent this.
Status: RESOLVED → REOPENED
Flags: needinfo?(gduan)
Resolution: FIXED → ---
Comment on attachment 8592907 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

Thanks Kevin.

Hi Ricky,
could you check this patch again? I should put those path string inside '"'.
Flags: needinfo?(gduan)
Attachment #8592907 - Flags: review?(ricky060709)
Comment on attachment 8592907 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

gaia-try is green. r+ again.
Attachment #8592907 - Flags: review?(ricky060709) → review+
Comment on attachment 8586713 [details] [review]
[gaia] cctuan:1101387 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/29291
Attachment #8586713 - Attachment is obsolete: true
Whiteboard: checkin-needed
gaia-try is all green, but checkin-needed seems not work , so I manually merge to master again,
https://github.com/mozilla-b2g/gaia/commit/b74f509f7fb422dd917a1f671201508714d98c09
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
checkin-needed is a bug keyword, not something you put on the whiteboard
Whiteboard: checkin-needed
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.