1101486 - [Icc] Consider unifying the argument set of unlockCardLock and setCardLock API.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a follow-up of Bug #1052825 +++

In current design, icc.unlockCardLock()/icc.setCardLock() API has different set of argument based on the lockType caller operate with. For example,

- unlocking pin
icc.unlockCardLock({
 lockType: "pin",
 pin: "1234"
});

- unlocking puk
icc.unlockCardLock({
 lockType: "puk",
 puk: "12345678",
 newPin: "1234"
});

- enabling pin
icc.unlockCardLock({
 lockType: "pin",
 pin: "12345678",
 enabled: true
});

- enabling pin2
icc.unlockCardLock({
 lockType: "pin",
 pin2: "12345678",
 enabled: true
});

- changing pin password
icc.unlockCardLock({
 lockType: "pin",
 pin: "12345678",
 newPin: "00000000"
});

- changing pin2 password
icc.unlockCardLock({
 lockType: "pin",
 pin: "12345678",
 newPin: "00000000"
});

It's quite annoying. :(
So in this bug, I would like to unify the argument, use "password" for all lockType. 

e.g.
icc.unlockCardLock({
 lockType: "pin",
 password: "1234"
});

How does this sound?

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

+1 to the proposal!

Comment 2

[BMO Automation]

Firefox OS is not being worked on