Closed Bug 1101486 Opened 10 years ago Closed 7 years ago

[Icc] Consider unifying the argument set of unlockCardLock and setCardLock API.

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: edgar, Unassigned)

References

Details

+++ This bug was initially created as a follow-up of Bug #1052825 +++ In current design, icc.unlockCardLock()/icc.setCardLock() API has different set of argument based on the lockType caller operate with. For example, - unlocking pin icc.unlockCardLock({ lockType: "pin", pin: "1234" }); - unlocking puk icc.unlockCardLock({ lockType: "puk", puk: "12345678", newPin: "1234" }); - enabling pin icc.unlockCardLock({ lockType: "pin", pin: "12345678", enabled: true }); - enabling pin2 icc.unlockCardLock({ lockType: "pin", pin2: "12345678", enabled: true }); - changing pin password icc.unlockCardLock({ lockType: "pin", pin: "12345678", newPin: "00000000" }); - changing pin2 password icc.unlockCardLock({ lockType: "pin", pin: "12345678", newPin: "00000000" }); It's quite annoying. :( So in this bug, I would like to unify the argument, use "password" for all lockType. e.g. icc.unlockCardLock({ lockType: "pin", password: "1234" }); How does this sound?
+1 to the proposal!
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.