1101494 - Guest mode doesn't work for rooms on a fresh profile (or if you haven't copied a url for 30 days)

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

STR:

1) Start up Firefox with a fresh profile
2) Try and create a room

-> It fails, no error message is displayed.

It will fail for any user that is using Loop in guest mode and haven't copied a call url in the last 30 days.

Comment 1

[Mark Banner (:standard8)]

Attachment: [checked in] Fix joining a room in guest mode

This fixes joining a room in guest mode by using the guest string if we're not logged in.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8525379 [details] [diff] [review]
[checked in] Fix joining a room in guest mode

Review of attachment 8525379 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: browser/components/loop/LoopRooms.jsm
@@ +5,5 @@
>  
>  const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
>  
>  Cu.import("resource://gre/modules/XPCOMUtils.jsm");
> +Cu.import("resource://gre/modules/Services.jsm");

I *think* this belongs to a different patch...

@@ +332,5 @@
> +    if (MozLoopService.userProfile && MozLoopService.userProfile.email) {
> +      displayName = MozLoopService.userProfile.email;
> +    } else {
> +      let stringBundle =
> +        Services.strings.createBundle('chrome://browser/locale/loop/loop.properties');

Can you make this a global lazyGetter called 'gLoopBundle'? Oh, and double quotes are the preferred taste around these parts ;)

::: browser/components/loop/test/xpcshell/test_looprooms.js
@@ +340,5 @@
> +add_task(function* test_joinRoomGuest() {
> +  // We need these set up for getting the email address.
> +  let roomToken = "_nxD4V4FflQ";
> +  let joinedData = yield LoopRooms.promise("join", roomToken);
> +  Assert.equal(joinedData.action, "join");

We also forgot to do `clearUserPref` for the test below... can you add that, please?

Comment 3

[Mark Banner (:standard8)]

Attachment: WIP Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not.

This is a tidied up patch of what I worked on with Mike earlier. Just have to finish fixing up the unit tests.

Comment 4

[u279076]

What branches does this affect?

Comment 5

[Maire Reavy [:mreavy]]

This was introduced with the new Rooms code.  We will want to uplift this to Fx35, but Beta (Fx34) is unaffected.

Comment 6

[u279076]

[Tracking Requested - why for this release]: needed for Firefox Hello 35

Comment 7

[Mark Banner (:standard8)]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> >  Cu.import("resource://gre/modules/XPCOMUtils.jsm");
> > +Cu.import("resource://gre/modules/Services.jsm");
> 
> I *think* this belongs to a different patch...

I'm landing this one first, and we need it for the Services.strings part addition ;-)

Comment 8

[Mark Banner (:standard8)]

First part landed:

https://hg.mozilla.org/integration/fx-team/rev/90307470c347

Comment 9

[Mark Banner (:standard8)]

Attachment: WIP Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not v2

Updated WIP

Comment 10

[Mark Banner (:standard8)]

Attachment: Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not.

Updated patch that fixes tests and gets them working.

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 8525607 [details] [diff] [review]
Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not.

r=me on the interdiff

Comment 12

[Mike de Boer [:mikedeboer]]

Comment on attachment 8525607 [details] [diff] [review]
Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not.

Review of attachment 8525607 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 13

[Mike de Boer [:mikedeboer]]

Try run might be wise, before we land this ;)

Comment 14

[Mark Banner (:standard8)]

Pushed:

https://hg.mozilla.org/integration/fx-team/rev/ef7bfca8a59f

Maire & Randell are going to watch this.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/90307470c347

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef7bfca8a59f

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8525379 [details] [diff] [review]
[checked in] Fix joining a room in guest mode

Approval Request Comment
[Feature/regressing bug #]: N/A
Mus-have fix for Rooms code for 35
[Describe test coverage new/current, TBPL]: on m-c, tested manually
[Risks and why]: low risk
[String/UUID change made/needed]: none

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8525607 [details] [diff] [review]
Guest mode doesn't work for rooms on a fresh profile - handle late guest registration, and keep track of when rooms are created to know if to automatically register or not.

Approval Request Comment
[Feature/regressing bug #]: N/A
Mus-have fix for Rooms code for 35
[Describe test coverage new/current, TBPL]: on m-c, tested manually
[Risks and why]: low risk
[String/UUID change made/needed]: none

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54ff7db0635f
https://hg.mozilla.org/releases/mozilla-aurora/rev/6908b4d5326e

Comment 20

[Paul Silaghi, QA [:pauly]]

Verified fixed 36.0a2 (2014-12-17), 35b4 Win 7