As bug 1094614 comment 8 and 11 pointed out, we need to add lock to avoid mCodec being changed while being checked.
Created attachment 8551205 [details] [diff] [review] Bug-1101565-Add-locks-when-reading-mCodec.patch Add locks when reading mCodec in MediaCodecProxy.cpp
Attachment #8551205 - Flags: review?(sotaro.ikeda.g)
(In reply to Blake Wu [:bwu][:blakewu] from comment #1) > Created attachment 8551205 [details] [diff] [review] > Bug-1101565-Add-locks-when-reading-mCodec.patch > > Add locks when reading mCodec in MediaCodecProxy.cpp To be more clear, Add locks to those functions which read/check mCodec.
Attachment #8551205 - Flags: review?(sotaro.ikeda.g) → review+
Created attachment 8551617 [details] [diff] [review] Bug-1101565-Add-locks-when-reading-mCodec-Final.patch Carry r+ from sotaro.
Building results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aceecc196d9 No need to run test cases since the pref is not enabled yet.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.