[FFOS] Some functions (like Input) in MediaCodecProxy lack mutex lock

RESOLVED FIXED in mozilla38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bwu, Assigned: bwu)

Tracking

unspecified
mozilla38
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
As bug 1094614 comment 8 and 11 pointed out, we need to add lock to avoid mCodec being changed while being checked.
(Assignee)

Comment 1

4 years ago
Created attachment 8551205 [details] [diff] [review]
Bug-1101565-Add-locks-when-reading-mCodec.patch

Add locks when reading mCodec in MediaCodecProxy.cpp
Attachment #8551205 - Flags: review?(sotaro.ikeda.g)
(Assignee)

Comment 2

4 years ago
(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> Created attachment 8551205 [details] [diff] [review]
> Bug-1101565-Add-locks-when-reading-mCodec.patch
> 
> Add locks when reading mCodec in MediaCodecProxy.cpp
To be more clear,
Add locks to those functions which read/check mCodec.

Updated

4 years ago
Attachment #8551205 - Flags: review?(sotaro.ikeda.g) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8551617 [details] [diff] [review]
Bug-1101565-Add-locks-when-reading-mCodec-Final.patch

Carry r+ from sotaro.
Attachment #8551205 - Attachment is obsolete: true
Attachment #8551617 - Flags: review+
(Assignee)

Comment 4

4 years ago
Building results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aceecc196d9
No need to run test cases since the pref is not enabled yet.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/147d4f71335e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.