Closed Bug 1101565 Opened 5 years ago Closed 5 years ago

[FFOS] Some functions (like Input) in MediaCodecProxy lack mutex lock

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: bwu, Assigned: bwu)

Details

Attachments

(1 file, 1 obsolete file)

As bug 1094614 comment 8 and 11 pointed out, we need to add lock to avoid mCodec being changed while being checked.
Add locks when reading mCodec in MediaCodecProxy.cpp
Attachment #8551205 - Flags: review?(sotaro.ikeda.g)
(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> Created attachment 8551205 [details] [diff] [review]
> Bug-1101565-Add-locks-when-reading-mCodec.patch
> 
> Add locks when reading mCodec in MediaCodecProxy.cpp
To be more clear,
Add locks to those functions which read/check mCodec.
Attachment #8551205 - Flags: review?(sotaro.ikeda.g) → review+
Carry r+ from sotaro.
Attachment #8551205 - Attachment is obsolete: true
Attachment #8551617 - Flags: review+
Building results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aceecc196d9
No need to run test cases since the pref is not enabled yet.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/147d4f71335e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.