Closed
Bug 1101565
Opened 11 years ago
Closed 11 years ago
[FFOS] Some functions (like Input) in MediaCodecProxy lack mutex lock
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: bwu, Assigned: bwu)
Details
Attachments
(1 file, 1 obsolete file)
|
2.50 KB,
patch
|
bwu
:
review+
|
Details | Diff | Splinter Review |
As bug 1094614 comment 8 and 11 pointed out, we need to add lock to avoid mCodec being changed while being checked.
|
Assignee | |
Comment 1•11 years ago
|
||
Add locks when reading mCodec in MediaCodecProxy.cpp
Attachment #8551205 -
Flags: review?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 2•11 years ago
|
||
(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> Created attachment 8551205 [details] [diff] [review]
> Bug-1101565-Add-locks-when-reading-mCodec.patch
>
> Add locks when reading mCodec in MediaCodecProxy.cpp
To be more clear,
Add locks to those functions which read/check mCodec.
|
||
Updated•11 years ago
|
Attachment #8551205 -
Flags: review?(sotaro.ikeda.g) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Carry r+ from sotaro.
Attachment #8551205 -
Attachment is obsolete: true
Attachment #8551617 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Building results look good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=0aceecc196d9
No need to run test cases since the pref is not enabled yet.
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•