1101584 - nsContentUtils::GetUTFOrigin should check if the URI has the nsIURIWithPrincipal interface.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: origin.patch

Comment 1

[Andrea Marchesini [:baku]]

this bug is created because of bug 1058470 comment 23.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Can you add a testcase?

For example, loading an iframe from a blob: URI and then checking its location.origin.

Or setting the href of an <a> element to a blob: URI and then checking its .origin.

Also, don't we need equivalent changes to nsContentUtils::GetASCIIOrigin?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: origin.patch

do you mean this kind of test?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8525378 [details] [diff] [review]
origin.patch

Yep, like that.  r=me, since I've clearly been looking at this.

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e604ebfc313

Comment 6

[Andrea Marchesini [:baku]]

Attachment: patch2.patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8525490 [details] [diff] [review]
patch2.patch

I'm not totally convinced we want to deal with uriWithPrincipal at all in these methods (feel like they make the methods do something magical, not something that the caller expects), but since bz was ok with the first patch, fine.
And looks like URIWithPrincipal is for nsHostObjectURI only atm.

Comment 8

[Andrea Marchesini [:baku]]

Attachment: origin.patch

patch merged: https://tbpl.mozilla.org/?tree=Try&rev=5259cc02e97f

Comment 9

[Andrea Marchesini [:baku]]

Attachment: origin.patch

comment added

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back out the original patch in https://hg.mozilla.org/integration/mozilla-inbound/rev/df4b53792111 because I couldn't keep holding the tree closed for the fix to land.

Comment 11

[Andrea Marchesini [:baku]]

The new patch fixes the problem. Sorry for the waiting for the new patch.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c5592132500

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1c5592132500