1101596 - Ship-it should store also the shipped date

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

We are storing the "submittedAt" date but we don't store the date the build has been pushed live (status=postrelease)
We are going to need this information if we want to replace product details by ship-it.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Bug-1101596-Ship-it-should-store-also-the-shipped-da.patch

John, it would be nice to update this field once a build status is updated to "postrelease"

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8525362 [details] [diff] [review]
0001-Bug-1101596-Ship-it-should-store-also-the-shipped-da.patch

Review of attachment 8525362 [details] [diff] [review]:
-----------------------------------------------------------------

Is this just part 1 of a series of patches? It obviously doesn't do anything to get shippedAt set when we actually ship a release. Maybe you're taking care of that in another bug?

::: migrate_repo/versions/008_Add_shipped_at.py
@@ +10,5 @@
> +def upgrade(migrate_engine):
> +    metadata = MetaData(bind=migrate_engine)
> +
> +    def add_shippedAt(table):
> +        shippedAt = Column('shippedAt', DateTime(pytz.utc), default=datetime.utcnow)

This default seems fine, but what's the plan for adjusting the shippedAt column for all the old releases? If we had a csv or something with the correct dates, we could probably adjust them as part of the upgrade, or do a one-off afterwards.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 8525362 [details] [diff] [review]
0001-Bug-1101596-Ship-it-should-store-also-the-shipped-da.patch

Review of attachment 8525362 [details] [diff] [review]:
-----------------------------------------------------------------

Removing review for now, see comment #2

Comment 4

[[e-mail] (:bhearsum)]

Mass component change for ship it bugs.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> This default seems fine, but what's the plan for adjusting the shippedAt
> column for all the old releases? If we had a csv or something with the
> correct dates, we could probably adjust them as part of the upgrade, or do a
> one-off afterwards.
I can take care of that. Would you be OK if I provide a series of (my)SQL queries for this?
Thanks

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #5)
> (In reply to Ben Hearsum [:bhearsum] from comment #2)
> > This default seems fine, but what's the plan for adjusting the shippedAt
> > column for all the old releases? If we had a csv or something with the
> > correct dates, we could probably adjust them as part of the upgrade, or do a
> > one-off afterwards.
> I can take care of that. Would you be OK if I provide a series of (my)SQL
> queries for this?
> Thanks

Yeah, that should be fine.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Attachment: Add the new field in the db

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Implemented and deployed.