Closed Bug 1101619 Opened 5 years ago Closed 5 years ago

[Messages][RTL] Location of status (error, delivered, read) icon at Report panel seems wrong

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, minor)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
2.2 S1 (5dec)

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

(Keywords: rtl, Whiteboard: [p=1])

Attachments

(4 files)

Location of "error" icon at Report panel seems wrong. See attached screenshots.
Hey Ahmed,

Could you please advise how it should be? See attachment 8525383 [details] for the current "error" icon location in RTL.

Thanks!
Flags: needinfo?(nefzaoui.ahmed)
Sounds like a missing background-position override :)
Yep, the icon should be on the far right :)
Flags: needinfo?(nefzaoui.ahmed)
Summary: [Messages][RTL] Location of "error" icon at Report panel seems wrong → [Messages][RTL] Location of status (error, delivered, read) icon at Report panel seems wrong
Hey Steve,

Here is a small patch to resolve this issue.

Could you please review it?

Thanks!
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Attachment #8527627 - Flags: review?(schung)
Comment on attachment 8527627 [details] [review]
GitHub pull request URL

Looks good, thanks!
Attachment #8527627 - Flags: review?(schung) → review+
Target Milestone: --- → 2.2 S1 (5dec)
(In reply to Steve Chung [:steveck] from comment #6)
> Comment on attachment 8527627 [details] [review]
> GitHub pull request URL
> 
> Looks good, thanks!

Thanks for review! Treeherder is green now (with one known and unrelated intermittent).

Master: https://github.com/mozilla-b2g/gaia/commit/cffce8975a29d9a7e1a98b2214866bf6cc1fdd8f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15931/
Flags: in-moztrap+
Attached video Verify_Pass.mp4
This problem is verified pass on latest build of Flame 2.2, Flame 3.0, N5 2.2 and N5 3.0.
The STR is as follow:
1. Set your phone language to Arabic, there is a message send failed.
2. Launch Messages and open the conversation which contain the sending failed message.
3. Long press the message.
4. Select "View message report" and observe the error icon.
Actual result: The error icon is displayed at right side of "message could not be sent" (The delivered and read icons also displayed at right side of "Delivered:..." text ).
See attachment: Verify_Pass.mp4
Rate: 0/5

Device: Flame 2.2 (Pass)
Build ID               20150525162504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/115112d51e08
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.202102
Firmware Date          Mon May 25 20:21:12 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.192755
Firmware Date          Mon May 25 19:28:07 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (Pass)
Build ID               20150525002504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.041303
Firmware Date          Mon May 25 04:13:19 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.192207
Firmware Date          Mon May 25 19:22:24 EDT 2015
Bootloader             HHZ12f

Thanks!
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.