Closed Bug 1101743 Opened 7 years ago Closed 10 months ago

Allow multi-select password deletion

Categories

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: liuche, Unassigned)

References

Details

I'm not sure what the UI for this would be, but we should allow showing and deleting of passwords, if not in an entry's detailed account, then in the main list of all passwords.
We have a long-press intent that would make sense from the "list" view.

Options to choose from would be: Reveal (password), Copy (password), Delete (log in).
Duplicate of this bug: 1101076
I was thinking about this, and I think displaying the action bar (like it currently does with text selection) is what I'd intuitively want to do from a list page - something like what the Gmail app does for conversations in your inbox. If we do that, "Copy password" doesn't make sense from a multiple item selection standpoint, and "Reveal/Peek" may or may not make sense, but this would allow for mass-deletions.

Copy and Reveal could be done on the "details" page (and also opening the page auto-filled with username/password, bug 1109382).

I like using the action bar better than a context menu - I think it makes the page feel more "native" and simple.
(In reply to Chenxia Liu [:liuche] from comment #3)
> I was thinking about this, and I think displaying the action bar (like it
> currently does with text selection) is what I'd intuitively want to do from
> a list page - something like what the Gmail app does for conversations in
> your inbox. If we do that, "Copy password" doesn't make sense from a
> multiple item selection standpoint, and "Reveal/Peek" may or may not make
> sense, but this would allow for mass-deletions.
> 
> Copy and Reveal could be done on the "details" page (and also opening the
> page auto-filled with username/password, bug 1109382).
> 
> I like using the action bar better than a context menu - I think it makes
> the page feel more "native" and simple.

Wesj has been pushing for this style of UI too. It would work for Downloads.
Simplifying this bug to just include deletion of passwords.

Long-press of an item should select the item (instead of doing text selection on item text) and open up the action bar with "delete" icon.

We should use the Android trash/delete icon, although I'm not sure how/if we can get access to that.

Ideally this functionality could be used by the other about:pages, though that could be a follow-up.
Summary: Allow showing and deleting of passwords from about:passwords → Allow multi-select password deletion
Depends on: mobile-passwords
No longer depends on: password-ui
Depends on: password-ui
No longer depends on: mobile-passwords
No longer depends on: password-ui
How about swipe to right to delete?  Possibly with an "undo" option, like iOS and Android do natively?

This will require improving the "I deleted a PW" code to be more intelligient: right now, we wait for the storage changed event, show the spinner, and reload the entire list.  We can do better.
Flags: needinfo?(alam)
(In reply to Nick Alexander :nalexander from comment #6)
> How about swipe to right to delete?  Possibly with an "undo" option, like
> iOS and Android do natively?
> 
> This will require improving the "I deleted a PW" code to be more
> intelligient: right now, we wait for the storage changed event, show the
> spinner, and reload the entire list.  We can do better.

I like swiping to delete but that doesn't really enable "multi select" in the same way.

In the current Gmail app on Android (and many other lists based UI) is kind of what I'm thinking. After selecting a couple items, leveraging the Action Bar for icons/actions would be great.
Flags: needinfo?(alam)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.