e10s - browser_bug427559.js

RESOLVED FIXED in Firefox 38

Status

()

Firefox
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Neil Deakin (away until Feb 4))

Tracking

(Blocks: 1 bug)

Trunk
Firefox 38
x86_64
Windows 8.1
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +
qe-verify -

Firefox Tracking Flags

(e10s+, firefox38 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This test consistently fails because it checks a wrapped window against an unwrapped window - it tries to do focus checks, but it's not clear that even if we fixed the wrapper situation, the windows are actually the same, and/or if the test works this way in e10s. It's more likely it needs to use a frame script to check that focus for the content process is correct... maybe?
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
tracking-e10s: ? → +
(Assignee)

Updated

3 years ago
Depends on: 921935
(Assignee)

Comment 1

3 years ago
This test will need to wait until the blur/focus events happen in the child tab, then inform the parent that the focus has moved to the body.
(Assignee)

Comment 2

3 years ago
Created attachment 8565792 [details] [diff] [review]
browser_bug427559

This does the job and lets us enable the test.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #8565792 - Flags: review?(gijskruitbosch+bugs)

Updated

3 years ago
Iteration: --- → 38.3 - 23 Feb
(Assignee)

Updated

3 years ago
Points: 5 → 2
(Reporter)

Comment 3

3 years ago
Comment on attachment 8565792 [details] [diff] [review]
browser_bug427559

Review of attachment 8565792 [details] [diff] [review]:
-----------------------------------------------------------------

You should trypush + retriggers to make sure that this really works on try, too, if you haven't already. :-)

::: browser/base/content/test/general/browser_bug427559.js
@@ +22,1 @@
>      setTimeout(function () {

While we're here, can we make this use executeSoon?

@@ +31,5 @@
> +        removeEventListener("focus", focusedWindow, true);
> +
> +        // Make sure focus is given to the window because the element is now gone
> +        is(browser.contentDocumentAsCPOW.activeElement.localName, "body", "body is focused");
> +        

Nit: whitespace
Attachment #8565792 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/18fbec59acaa
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.