1102015 - e10s - browser_bug427559.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

This test consistently fails because it checks a wrapped window against an unwrapped window - it tries to do focus checks, but it's not clear that even if we fixed the wrapper situation, the windows are actually the same, and/or if the test works this way in e10s. It's more likely it needs to use a frame script to check that focus for the content process is correct... maybe?

Comment 1

[Neil Deakin]

This test will need to wait until the blur/focus events happen in the child tab, then inform the parent that the focus has moved to the body.

Comment 2

[Neil Deakin]

Attachment: browser_bug427559

This does the job and lets us enable the test.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8565792 [details] [diff] [review]
browser_bug427559

Review of attachment 8565792 [details] [diff] [review]:
-----------------------------------------------------------------

You should trypush + retriggers to make sure that this really works on try, too, if you haven't already. :-)

::: browser/base/content/test/general/browser_bug427559.js
@@ +22,1 @@
>      setTimeout(function () {

While we're here, can we make this use executeSoon?

@@ +31,5 @@
> +        removeEventListener("focus", focusedWindow, true);
> +
> +        // Make sure focus is given to the window because the element is now gone
> +        is(browser.contentDocumentAsCPOW.activeElement.localName, "body", "body is focused");
> +        

Nit: whitespace

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18fbec59acaa