Closed Bug 1102017 Opened 5 years ago Closed 4 years ago

e10s - fix browser_bug462289.js

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: Gijs, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

1064 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js | middle-button mousedown on selected tab2 does not activate tab - Didn't expect [object XULElement], but got it
Stack trace:
chrome://mochikit/content/browser-test.js:test_isnot:838
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step6:72
null:null:0

Not sure what's going on here, but the previous comment indicates this used to crash and time out before... so, progress? The test still needs fixing, however!
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
I'm getting the same 3 failures in this test on e10s and non-e10s

Browser Chrome Test Summary
	Passed: 11
	Failed: 3
	Todo: 0
*** End BrowserChrome Test Results ***
The following tests failed:
26 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | tab key to selected tab1 activates tab - Got [object HTMLInputElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step3:41
27 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | 3rd click on activated tab1 keeps tab activated - Got [object HTMLInputElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step4:50
28 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug462289.js | click on tab2 while tab1 is activated activates tab - Got [object XULElement], expected [object XULElement]
Stack trace:
chrome://mochikit/content/browser-test.js:test_is:940
chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug462289.js:step5:61
Pretty sure bug 1009628 broke this by adjusting focus later than we used to.
Blocks: 1009628
Keywords: regression
OS: Windows 8.1 → All
Hardware: x86_64 → All
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8726151 - Flags: review?(mconley)
Comment on attachment 8726151 [details] [diff] [review]
patch

Review of attachment 8726151 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Dao!
Attachment #8726151 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/0e4a7aef432e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.