1102024 - hover state of the "change search setting" button is really very light

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: hover state really light

The current hover state of the "Change Search Settings" button is really light making it difficult to distinguish it as clickable button. We should probably make this a bit darker so it's easier to see.

Attached a gif that demonstrates the issue.

Comment 1

[Liz Henry (:lizzard)]

[Tracking Requested - why for this release]:  We want to make it clear from the beginning that users can change their search settings.

Comment 2

[Florian Quèze [:florian]]

Fixed by https://hg.mozilla.org/releases/mozilla-beta/rev/8622ff2cb47b (landed in bug 1088660 comment 45).

For the record, I requested the new hover color from phlsa, who said "Let's use #d3d3d3 as the hover color, just like in e.g. the bookmarks menu (leaving the non-hover state as it is now).".

After testing, I also requested from him a new border color, irc log:

Florian: phlsa: I applied your new color for the hovered "change search settings" button (#d3d3d3) and the top border doesn't seem dark enough anymore. I think you took that new background color from the bottom of the bookmark panel. Do you happen to also have the hovered top border color handy?

phlsa: Florian: bdbebe

Florian: phlsa: thanks! Looks much better.

phlsa: :)

Florian: that border is barely noticeable, but no longer looks broken :)