1102038 - the "Change Search Settings" button and the open search items cannot be used via the keyboard

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

Attachment: buttonSelectionIssue.gif

The "Change Search Settings" button cannot be selected when using the keyboard. Using the down arrow and the TAB key will skip the button.

Attached a .gif that demonstrates the issue.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

[Tracking Requested - why for this release]: This is important for the accessibility of the search UI.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

We decided this wasn't necessary for the first iteration (there are other ways to open the search settings via keyboard).

Comment 3

[Florian Quèze [:florian]]

Extending this to also include open search items, as I think it makes sense to fix both at once.

I discussed this with Philipp this morning. After the decision we made in bug 1104142 about the way tab should behave in the search panel, this is now easier to address. Here's the behavior we agreed on:
- when the last one-off button is highlighted, pressing <tab> or <down> should select the search setting (or first open search item if there's any).
- when the search setting item is highlighted, pressing <down> should clear the selection. <tab> should move the focus out of the panel.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Florian, can you estimate this?

Comment 5

[Florian Quèze [:florian]]

Attachment: Patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=092abea2d289

Comment 6

[Florian Quèze [:florian]]

Attachment: Patch

Forgot to hg add a file in attachment 8558028 [details] [diff] [review], pushed to try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f3c578b1549

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/ab00a9cbd01b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab00a9cbd01b

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8558032 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1088660
[User impact if declined]: impossible to add open search engines with only the keyboard.
[Describe test coverage new/current, TreeHerder]: this patch contains tests, added above the tests landed in bug 1124900.
[Risks and why]: I would like to have this shipping soon, but I think it's too risky for beta at this point. This depends on the refactoring in bug 1124904.
[String/UUID change made/needed]: none.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

There's a fair amount of code change required for this fix. Can this be verified on Nightly before uplifting to Aurora?

Comment 11

[Florian Quèze [:florian]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #10)
> There's a fair amount of code change required for this fix. Can this be
> verified on Nightly before uplifting to Aurora?

Seems totally reasonable to me, we still have time to land in aurora.

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through verification using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-02-09-03-02-04-mozilla-central/

Test Cases:
===========

- ensured that you could still go through the listed suggestions terms using the up/down arrows
- ensured that you can select every item in the search bar using the up/down arrows (suggestions, one-click search engines, change search settings button etc..)
- ensured that you can only select the one-click search engines and the search url text box when using tab
- ensured that once you land on the "Change Search Settings" button, pressing "Enter" opens the "Search" preferences without any issues
- ensured that you can select and press "Enter" on "one-click" search engines
- ensured that you can select and press "Enter" on "one-click" search engines and search suggestions while using the arrow keys
- ensured that you can select the "Change Search Settings" button when either going through the list from the top or the bottom

OS's Used:
==========

- Win 8.1 x64
- OSX 10.10.2
- Ubuntu 14.04.1

possible issues:
================

- when selecting the "Change Search Settings" button with the keyboard on Windows/Linux, the button isn't highlighted making it very difficult to see if it has been selected. On OSX, you can tell the button has gotten a bit darker when it's selected. I logged into my Win machine remotely and noticed the same thing happening so I don't think it's related to the VMs.

- when pressing tab, once you hit the "Change Search Settings", you'll escape the search toolbar and continue through the other text boxes on current page. I'm not sure if this is intended behavior or the user should be confined to the search toolbar if he's already in it and pressing tab. Once the user does "escape" the search toolbar, he can eventually return after pressing tab and going through the entire page. I don't think this is a real issue but just double checking.

Comment 13

[Florian Quèze [:florian]]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #12)

Thanks!

> - when selecting the "Change Search Settings" button with the keyboard on
> Windows/Linux, the button isn't highlighted making it very difficult to see
> if it has been selected.

Looks like I forgot to do on Windows/Linux the CSS changes I did on Mac at https://hg.mozilla.org/mozilla-central/rev/ab00a9cbd01b#l6.1

Patch coming soon.

> - when pressing tab, once you hit the "Change Search Settings", you'll
> escape the search toolbar and continue through the other text boxes on
> current page.

I think that's the expected behavior since bug 1104142.

Comment 14

[Florian Quèze [:florian]]

Attachment: CSS follow-up Windows/Linux

Adding this trivial patch in the same bug as this is not marked verified yet, and I'll fold the 2 patches together to request aurora approval.

Comment 15

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/a83fc66f8541

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a83fc66f8541

Comment 17

[Kamil Jozwiak [:kjozwiak]]

Went through verification using the following build:
* http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-02-17-03-02-13-mozilla-central/

- Went through the test cases listed in comment # 12
- ensured that the CSS transition occurs on OSX/Win/Linux
- ensured that "Change Search Settings" changes correctly when using the arrow keys to select
- ensured that "Change Search Settings" changes correctly when using the tab key to select

Comment 18

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8558032 [details] [diff] [review]
Patch

Now that this has been verified, Aurora+

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8129c0467541

Comment 20

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 37 beta 1 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.