Closed Bug 1102146 Opened 5 years ago Closed 5 years ago

No longer need multiple GET requests for individual rooms after a getAll

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

(Whiteboard: [rooms])

Attachments

(1 file)

Since bug 1087041 landed in the server (and is in the production version), we no longer need to do multiple GET requests on individual rooms to get the full details - the details are in the getAll information.

Hence we can drop the requests and save the request time.
Status: NEW → ASSIGNED
Iteration: --- → 36.3
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Whiteboard: [rooms]
Flags: needinfo?(mmucci)
Attachment #8526041 - Flags: review?(standard8)
Added to IT 36.3
Flags: needinfo?(mmucci)
Comment on attachment 8526041 [details] [diff] [review]
Patch v1: reduce the amount of HAWK requests for rooms getAll

Review of attachment 8526041 [details] [diff] [review]:
-----------------------------------------------------------------

r=Standard8 with the comment fixed.

::: browser/components/loop/LoopRooms.jsm
@@ +183,5 @@
>          if ("currSize" in room) {
>            delete room.currSize;
>          }
>          this.rooms.set(room.roomToken, room);
> +        

nit: whitespace on blank line.
Attachment #8526041 - Flags: review?(standard8) → review+
Somehow my hg fu failed me. Pushed a follow-up to _really_ address the comment: https://hg.mozilla.org/integration/fx-team/rev/da918fa50e5f
https://hg.mozilla.org/mozilla-central/rev/0cad1e05f689
https://hg.mozilla.org/mozilla-central/rev/da918fa50e5f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Flags: in-moztrap-
Comment on attachment 8526041 [details] [diff] [review]
Patch v1: reduce the amount of HAWK requests for rooms getAll

Approval Request Comment
[Risks and why]: Loop rooms code to speed up getting room details
also keeps code identical between 35 and 36 to increase testing impact
Simple patch to match server change.
[String/UUID change made/needed]: none
Attachment #8526041 - Flags: approval-mozilla-aurora?
Attachment #8526041 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.