1102146 - No longer need multiple GET requests for individual rooms after a getAll

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Since bug 1087041 landed in the server (and is in the production version), we no longer need to do multiple GET requests on individual rooms to get the full details - the details are in the getAll information.

Hence we can drop the requests and save the request time.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: reduce the amount of HAWK requests for rooms getAll

Comment 2

[Marco Mucci [:MarcoM]]

Added to IT 36.3

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8526041 [details] [diff] [review]
Patch v1: reduce the amount of HAWK requests for rooms getAll

Review of attachment 8526041 [details] [diff] [review]:
-----------------------------------------------------------------

r=Standard8 with the comment fixed.

::: browser/components/loop/LoopRooms.jsm
@@ +183,5 @@
>          if ("currSize" in room) {
>            delete room.currSize;
>          }
>          this.rooms.set(room.roomToken, room);
> +        

nit: whitespace on blank line.

Comment 4

[Mike de Boer [:mikedeboer]]

Pushed with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/0cad1e05f689

Comment 5

[Mike de Boer [:mikedeboer]]

Somehow my hg fu failed me. Pushed a follow-up to _really_ address the comment: https://hg.mozilla.org/integration/fx-team/rev/da918fa50e5f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0cad1e05f689
https://hg.mozilla.org/mozilla-central/rev/da918fa50e5f

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8526041 [details] [diff] [review]
Patch v1: reduce the amount of HAWK requests for rooms getAll

Approval Request Comment
[Risks and why]: Loop rooms code to speed up getting room details
also keeps code identical between 35 and 36 to increase testing impact
Simple patch to match server change.
[String/UUID change made/needed]: none

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c0b9a86649a
https://hg.mozilla.org/releases/mozilla-aurora/rev/d4d3fbf9e177