1102173 - [Rooms][Polish] Define and implement the final behaviour in the counter

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to define the final specs for the input field when creating a room. Feedback is welcome!

Comment 1

[Mónica UX/UI]

Attachment: Loop-v.1.1.1-Counter-Characters-Newroom.pdf

This is the final spec :)

Comment 2

[Cristian Rodriguez (:crdlc)]

Just idea for localization:

Positive values:

posCounter = {[ plural(value) ]}
posCounter[zero] = Maximum reached
posCounter[one] = One character left
posCounter[two] = Two characters left
posCounter[few] = {{value}} characters left
posCounter[many] = {{value}} characters left
posCounter[other] = {{value}} characters left

Negative values:

negCounter = {[ plural(value) ]}
negCounter[one] = Exceed in one character the limit
negCounter[two] = Exceed in two characters the limit
negCounter[few] = Exceed in {{value}} characters the limit
negCounter[many] = Exceed in {{value}} characters the limit
negCounter[other] = Exceed in {{value}} characters the limit

IMHO it seems more semantic than "-3 characters" for users like my mother or grandfather :)

What do you think?

Comment 3

[Cristian Rodriguez (:crdlc)]

Stealing the bug once this was defined and now we have to start implementing this behavior

Comment 4

[Cristian Rodriguez (:crdlc)]

Please Vicky, I need font-size, font-weight and color for this counter

Comment 5

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Empty field

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Typing room name

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Limit exceeded

Comment 9

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8527571 [details]
Typing room name

"left" word is missing in the character counter

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Typing room name v2

Comment 11

[Borja Salguero [:borjasalguero]]

Comment on attachment 8527568 [details]
Github pull request

Great job! R+! :)

Comment 12

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/4fecf6899429199ffe3a3c559710c2faf7aad51f