1102230 - Fix errors reported in the console when running the test suite

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

See attached patch for fixes;

 - 1 CSS declaration that is wrong
 - 'lastParam' is not a function
 - 'callback' is not a function

Bonus debugging helper that traps values that fail to clone. This way we can debug these cases easier as well.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: fix CSS and JS errors that appear in the test log

Comment 2

[Marco Mucci [:MarcoM]]

Added to IT 36.3

Comment 3

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8526025 [details] [diff] [review]
Patch v1: fix CSS and JS errors that appear in the test log

Review of attachment 8526025 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for the CSS modification.

Comment 4

[Mike de Boer [:mikedeboer]]

Thanks Matt!

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/29f4ed2cf97a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/29f4ed2cf97a

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8526025 [details] [diff] [review]
Patch v1: fix CSS and JS errors that appear in the test log

Approval Request Comment
[Risks and why]: Loop code to clean up errors in test logs when items are garbage collected due to async events, and fix a background color setting.
[String/UUID change made/needed]: none

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/77d42b18755a