Closed
Bug 1102230
Opened 10 years ago
Closed 10 years ago
Fix errors reported in the console when running the test suite
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35 fixed, firefox36 fixed)
backlog | Fx36+ |
People
(Reporter: mikedeboer, Assigned: mikedeboer)
References
Details
Attachments
(1 file)
5.20 KB,
patch
|
MattN
:
review+
NiKo
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
See attached patch for fixes; - 1 CSS declaration that is wrong - 'lastParam' is not a function - 'callback' is not a function Bonus debugging helper that traps values that fail to clone. This way we can debug these cases easier as well.
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8526025 -
Flags: review?(standard8)
Updated•10 years ago
|
backlog: --- → Fx36+
Assignee | ||
Updated•10 years ago
|
Attachment #8526025 -
Flags: review?(nperriault)
Comment on attachment 8526025 [details] [diff] [review] Patch v1: fix CSS and JS errors that appear in the test log Review of attachment 8526025 [details] [diff] [review]: ----------------------------------------------------------------- r+ for the CSS modification.
Attachment #8526025 -
Flags: review?(nperriault) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8526025 -
Flags: review?(standard8) → review?(MattN+bmo)
Updated•10 years ago
|
Attachment #8526025 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks Matt! Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/29f4ed2cf97a
https://hg.mozilla.org/mozilla-central/rev/29f4ed2cf97a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
status-firefox36:
--- → fixed
Flags: in-moztrap-
Comment 6•9 years ago
|
||
Comment on attachment 8526025 [details] [diff] [review] Patch v1: fix CSS and JS errors that appear in the test log Approval Request Comment [Risks and why]: Loop code to clean up errors in test logs when items are garbage collected due to async events, and fix a background color setting. [String/UUID change made/needed]: none
Attachment #8526025 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8526025 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
status-firefox35:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•