Closed Bug 1102230 Opened 10 years ago Closed 10 years ago

Fix errors reported in the console when running the test suite

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
backlog Fx36+

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

Attachments

(1 file)

See attached patch for fixes;

 - 1 CSS declaration that is wrong
 - 'lastParam' is not a function
 - 'callback' is not a function

Bonus debugging helper that traps values that fail to clone. This way we can debug these cases easier as well.
Flags: qe-verify-
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
backlog: --- → Fx36+
Added to IT 36.3
Flags: needinfo?(mmucci)
Attachment #8526025 - Flags: review?(nperriault)
Comment on attachment 8526025 [details] [diff] [review]
Patch v1: fix CSS and JS errors that appear in the test log

Review of attachment 8526025 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for the CSS modification.
Attachment #8526025 - Flags: review?(nperriault) → review+
Blocks: 1102477
Attachment #8526025 - Flags: review?(standard8) → review?(MattN+bmo)
Attachment #8526025 - Flags: review?(MattN+bmo) → review+
Blocks: 1102939
https://hg.mozilla.org/mozilla-central/rev/29f4ed2cf97a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Flags: in-moztrap-
Comment on attachment 8526025 [details] [diff] [review]
Patch v1: fix CSS and JS errors that appear in the test log

Approval Request Comment
[Risks and why]: Loop code to clean up errors in test logs when items are garbage collected due to async events, and fix a background color setting.
[String/UUID change made/needed]: none
Attachment #8526025 - Flags: approval-mozilla-aurora?
Attachment #8526025 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.