Closed
Bug 1102352
Opened 11 years ago
Closed 10 years ago
Call info page call items are misaligned
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(Not tracked)
RESOLVED
WORKSFORME
2.2 S1 (5dec)
People
(Reporter: drs, Assigned: drs)
References
Details
(Whiteboard: [planned-sprint c=1])
Attachments
(2 files)
|
58.65 KB,
image/png
|
Details | |
|
1.43 KB,
patch
|
gtorodelvalle
:
review+
|
Details | Diff | Splinter Review |
The call duration and direction indicators are misaligned with the call time fields on the call info view.
| Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 2.2 S1 (5dec)
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → drs.bugzilla
Whiteboard: [planned-sprint c=?] → [planned-sprint c=1]
| Assignee | ||
Comment 1•10 years ago
|
||
PR: https://github.com/mozilla-b2g/gaia/pull/26504
I wanted to combine the `background-position` and `background-repeat` properties into one statement, but it didn't render correctly with this for some reason.
Attachment #8529428 -
Flags: review?(gtorodelvalle)
| Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8529428 [details] [diff] [review]
Fix call info previous call items being misaligned in RTL.
Hi Doug, looking good to me and working just fine ;) Anyhow, I was wondering if there were some (performance?) reason why you used align-self instead of align-items. As I said, just wondering to use it this way in my code if needed :) Thanks!
Attachment #8529428 -
Flags: review?(gtorodelvalle) → review+
Comment 3•10 years ago
|
||
Just checked. This bug to be not occurring anymore.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 4•10 years ago
|
||
The patch seems to have never landed in gaia. Marking as works for me since we don't know which commit actually fixed the issue.
Resolution: FIXED → WORKSFORME
Updated•10 years ago
|
Flags: in-moztrap+
Comment 5•10 years ago
|
||
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15434/
You need to log in
before you can comment on or make changes to this bug.
Description
•