1102419 - whatsnew/firstrun config for Firefox 34.0/34.1

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

We'll want to enable the whatsnew/firstrun pages for both 34.0 and 34.1. I think we can just do this simply by adding the relevant prefs.

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

I think we'll also need a whatnew/firstrun experience for users who update from <34.0 to 35+. We don't need to do this now but do need to consider these users in the next cycle.

Comment 2

[Alex Gibson [:agibson]]

Just checking we're only enabling /whatsnew on 34.x for en-US users only here, correct?

Comment 3

[Holly Habstritt Gaal [:Habber]]

(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #1)
> I think we'll also need a whatnew/firstrun experience for users who update
> from <34.0 to 35+. We don't need to do this now but do need to consider
> these users in the next cycle.

Just a quick note about how we enable /firstrun. It is always on unless explicitly noted otherwise.

/whatsnew is enabled on a release to release basis. So we will consider enabling it for 35 if we have a reason to do so, like a new feature announcement or campaign. We will file a bug specific to 35 once we have that information. This bug will focus on 34.0-34.1.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

FYI. In a discussion between QA, releng and release coordination today we settled on calling these 34.0 and 34.0.5.   Please let me, lawrence, and bhearsum know if that isn't in line with what you all expect. Thanks!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

OK, so:
- whatsnew: en-US only, both for 34.0 and 34.0.5
- firstrun: all locales, for both versions

As Holly says, firstrun is already enabled by default.

We'll want a whatsnew patch similar to bug 1077643, though we can make it dependent on browser.search.showOneOffButtons rather than the more complicated conditions there.

We will need to coordinate on update configs for 34.0 to ensure they do not suppress whatsnew pages.

Comment 6

[Dave Townsend [:mossop]]

So the code in bug 1077643 uses a hardcoded URL for whatsnew, should we be doing the same here or just use startup.homepage_override_url?

Comment 7

[Alex Gibson [:agibson]]

Please also make sure to include the usual ?oldversion param in the /whatsnew URL. Thanks!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to Dave Townsend [:mossop] from comment #6)
> So the code in bug 1077643 uses a hardcoded URL for whatsnew, should we be
> doing the same here or just use startup.homepage_override_url?

Doesn't really matter either way (hardcoded in the pref vs. hardcoded in the code). We can put the pref in and only have it be read if the one off search pref is set, that probably makes the patch simplest.

Comment 9

[Dave Townsend [:mossop]]

Attachment: patch

So just this?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8527046 [details] [diff] [review]
patch

You will also need to set the startup.homepage_override_url pref to:

https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/whatsnew/?oldversion=%OLD_VERSION%

in browser/branding/official/pref/firefox-branding.js

Please also add a more visible/explicit comment about this being a one-off hack for 34 (even though we're only landing this on beta).

Comment 11

[Dave Townsend [:mossop]]

Attachment: patch

Comment 12

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-beta/rev/70114bfbbd70

Comment 13

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 34
Build Id:20141125180439
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64

FF 34.0.5
Build Id: 20141126041045
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64